Repository navigation
Read the code generators' features.json from comline-rust and comline-typescript - #25
Merged
Merged
Conversation
…-typescript Generation's combined features.json goes away (generation#159); each generator publishes its own. The two sources share the codegen matrix, so the site still shows one table. The latest version of each source holds the same subjects and states the combined file did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generation's combined
features.jsongoes away with ComlineProject/generation#159. Each generator now publishes its own at the repo root onmain(comline-rust 22110d8, comline-typescript 671f27e), with the samefeatureslist and only its own entry ingenerators.sources.toml: thecodegensource (generation) becomescodegen-rustandcodegen-typescript, both withmatrix = "codegen". The collector already combines sources that share a matrix (the wire matrix is built the same way).DATA.md: the conformance input is described as a generator's file.Checked locally with the collector on the old and new source sets: the newest version of each new source holds subjects
rustandtypescriptwith exactly the shard the oldcodegensource's newest version had (58 metric rows, same keys, samefeatures).One visible change: history. The old source had 16 versions from generation's log; the new ones start at the commit that added each file, so each has one version for now and the matrix's version picker starts there. The source ids change, so a saved
?a=codegen:...link no longer resolves; it is nowcodegen-rust:.../codegen-typescript:....Merge after generation#159 or before; the old source keeps working until generation drops the file.