Repository navigation
Bounds on types: re-pin core, generation, generators and language server - #111
Merged
Merged
Conversation
…erver (core#98 step 10)
added 2 commits
November 3, 2026 19:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 10 of the bounds rollout (ComlineProject/core#98, ComlineProject/core#197).
8f5dc91, generationc303722(here and infixtures/generators), comline-rust2d50fbf, comline-typescriptea9b9e2. The language server is pinned to Bounds on types: re-pin core and generation, hover shows the maximum language-server#97's head (9118953), which uses the same core, so the graph has one core.max.describe_projectpasses it on (maxbesidelen), and text (an array ofchar, such aschar[max 64]) is described as astringscalar, as before bounds.Merge after ComlineProject/language-server#97. Once that merges, move the language-server pin to its merge commit.
Round 2: the playground's generate request takes comline-codegen's default, so code generated here now runs validators on decode (
collect), as it does from the CLI.