Repository navigation
comline@2: datagram@3/comline@2 defaults, generated with facts (runtime#15) - #112
Merged
Merged
Conversation
…me#15)
Re-pins core (1dc294a), generation (83162ea), comline-rust (addca26),
comline-typescript (40cab74), the language server at language-server#98's
tip and the simulator at simulator#30's tip.
- The package's framing and handshake, core's defaults here, are frozen
into every protocol that writes none, as comline build does
(language-server's apply_package_wire), so the IR, the description and
the generated code show datagram@3 and comline@2.
- Generating a package that needs facts gives it a first version's,
from comline_core::compat::facts_of_context over the in-memory context.
The congregation carries a fixed id ("playground" in hex), which
comline@2 needs.
- describe_project adds each protocol's number and each call's wire
number, and the package connection with comline@2's parameters and the
Hello the generators embed, for the simulator.
- The connection inspector shows the handshake and its parameters, and
labels the numbers provisional; the frame log shows comline@2 messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ComlineProject/runtime#15, the last step: the playground follows core's flipped defaults (
datagram@3/comline@2, core#208) and generates with facts (generation#122).Merge order: language-server#98, then simulator#30, then this PR. It pins both of their branch tips, so after they merge it needs a re-pin to their merge commits.
Pins
1dc294aand generation83162ea, as the cli.addca26and comline-typescript40cab74, the two generators' main tips.0764367, language-server#98's tip.564851a, simulator#30's tip.The defaults
The playground interprets each file itself rather than through core's compiler, so nothing froze the package's framing and handshake into protocols that write none. An absent value now reads as the implicit
datagram@2/comline@1.interpret_projectnow applies them for the whole package, using the language server'sapply_package_wire, which mirrors core'sapply_package_framing/apply_package_handshakeandpackage_default_handshake. So the IR, the description and the generated code all showdatagram@3andcomline@2, ascomline buildwould.framing_ofreads an absent framing asIMPLICIT_FRAMING.Facts
facts::needed) gets a first version's fromcomline_core::compat::facts_of_context(context, "0.1.0"). That entry point already exists in core and takes no path, so no core PR was needed. Each parsed file's schema context holds its frozen units, as a build's would, and the congregation is now frozen (config_frozen) so the facts see itsid.706c617967726f756e64000000000000, which is "playground" in ASCII hex, zero-padded to 32 digits. It lives in the congregation asid. A fixed id keeps generated code the same from one visit to the next and needs no storage. A per-session id would change everyHelloon each reload.Simulator
describe_projectadds:number: the number its frames carry, fromfacts::addressing;call: its wire number underdatagram@3, else its position;connection: the package connection's framing and handshake,comline@2's four parameters, and the encodedHellofromfacts::hello, the same bytes the generators embed.simulator#30 frames
datagram@3by number and runscomline@2through the runtime'sComline2. The UI shows:datagram@3in the framing picker and the compare panel (10 combos);comline@2message decoded in the frame log.Tests
cargo testinwasm/: 15 pass. New tests cover a default package runningdatagram@3/comline@2; Rust and TypeScript generation with first-version facts (id, version, numbers); ajsonrpcpackage needing no facts; and the description's numbers andHello.comline@2handshake frames instead of two,datagram@3in the request detail and theauto →label, 10 compare combos, and the handshake row with its provisional note.