Skip to content

wasm: core's package-wire freeze, not the language server's copy - #113

Merged
Kinflou merged 1 commit into
masterfrom
comline2/shared-wire-facts
Nov 8, 2026
Merged

Kinflou merged 1 commit into
masterfrom
comline2/shared-wire-facts

Conversation

@Kinflou

@Kinflou Kinflou commented Nov 8, 2026

Copy link
Copy Markdown
Member

Follow-up to comline@2 (ComlineProject/runtime#15).

  • interpret_project froze the package's framing and handshake with the language server's source::apply_package_wire (a copy of core's private logic) over a re-read of CONGREGATION. It now calls core's schema::ir::package_wire::apply_package_wire (core#209) with context.config_frozen, the congregation it already froze. The schema-name half of the tuple that only existed for the old signature is gone.
  • Pins: core#209 (d11d82b), generation 55d3fdc, comline-rust#111 (be90c80), comline-typescript#137 (02ededc), language-server#99 (5c235fb).

Name-keyed rules left in the playground, on purpose: the simulator UI's framing selector (view.ts) lists the framings the simulator implements and locks the format to JSON for jsonrpc, and wasm/src/lib.rs checks handshake == "comline@2" to decide whether to build comline@2's hello. Both pick an implementation by its identity rather than judging an encoding's behaviour, and the playground can't declare third-party encodings (its congregation is in memory, with no profiles).

cargo test --manifest-path wasm/Cargo.toml and a wasm32-unknown-unknown check pass locally.

Merge last, after core#209, generation#123, comline-rust#111, comline-typescript#137, cli#138 and language-server#99.

Refs ComlineProject/runtime#15

The playground froze its package's framing and handshake through the
language server's copy of core's logic (playground#112), re-reading the
congregation text. It now calls core's
schema::ir::package_wire::apply_package_wire with the congregation it
already froze. Pins core#209, generation, comline-rust,
comline-typescript and language-server#99 on one core.

Refs ComlineProject/runtime#15
@Kinflou
Kinflou merged commit a66d301 into master Nov 8, 2026
2 checks passed
@Kinflou
Kinflou deleted the comline2/shared-wire-facts branch November 8, 2026 03:06
@Kinflou Kinflou moved this from Todo to Done in Comline Development Roadmap Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant