Repository navigation
wasm: core's package-wire freeze, not the language server's copy - #113
Merged
Merged
Conversation
The playground froze its package's framing and handshake through the language server's copy of core's logic (playground#112), re-reading the congregation text. It now calls core's schema::ir::package_wire::apply_package_wire with the congregation it already froze. Pins core#209, generation, comline-rust, comline-typescript and language-server#99 on one core. Refs ComlineProject/runtime#15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to
comline@2(ComlineProject/runtime#15).interpret_projectfroze the package's framing and handshake with the language server'ssource::apply_package_wire(a copy of core's private logic) over a re-read ofCONGREGATION. It now calls core'sschema::ir::package_wire::apply_package_wire(core#209) withcontext.config_frozen, the congregation it already froze. The schema-name half of the tuple that only existed for the old signature is gone.d11d82b), generation55d3fdc, comline-rust#111 (be90c80), comline-typescript#137 (02ededc), language-server#99 (5c235fb).Name-keyed rules left in the playground, on purpose: the simulator UI's framing selector (
view.ts) lists the framings the simulator implements and locks the format to JSON forjsonrpc, andwasm/src/lib.rscheckshandshake == "comline@2"to decide whether to buildcomline@2's hello. Both pick an implementation by its identity rather than judging an encoding's behaviour, and the playground can't declare third-party encodings (its congregation is in memory, with no profiles).cargo test --manifest-path wasm/Cargo.tomland awasm32-unknown-unknowncheck pass locally.Merge last, after core#209, generation#123, comline-rust#111, comline-typescript#137, cli#138 and language-server#99.
Refs ComlineProject/runtime#15