Repository navigation
Pin the editions cascade (core#217) - #114
Merged
Merged
Conversation
…editions cascade core b933209 (core#217), generation bb89a51, comline-rust de0b8e5, comline-typescript 9952c5a, language-server 4c5eb55.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin bump only, the last step of the language-editions cascade.
New pins:
b933209(Language editions: checked specification_version, deprecations and fixes core#217)bb89a51de0b8e59952c5a4c5eb55(Editions: config.idp's edition, deprecated words, and core's fixes as quick fixes language-server#101)No source changes. The playground's generated config already writes
specification_version = 1, and the build doesn't construct core'sDiagnosticdirectly.Tested locally:
cargo testpasses (15 tests), and so does thewasm32-unknown-unknownrelease build.Merge last, after language-server#101.
Refs ComlineProject/core#102