Repository navigation
CI hardening: pinned actions, wasm image, lint, Renovate - #115
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4 of the org CI overhaul for the playground.
What changed
deploy.yml:ci-wasmimage (by digest): Rust 1.99.1 with both wasm32 targets, wasm-bindgen 0.2.127, wasm-pack 0.15.1, binaryen. This removesrustup target addand thecurl ... | shwasm-pack installer. wasm-bindgen 0.2.127 is the versioncomline-simulator'sprepare.shasks for, so it installs nothing either.22) through SHA-pinnedsetup-node;corepack enableprovidesyarn, which hands over to the committed Yarn 4.18.0 release (yarnPath).runs-on: ubuntu-24.04,timeout-minuteson every job, top-levelpermissions: contents: read,persist-credentials: false.pages: writeandid-token: writeare on thedeployjob only. harden-runner (audit) on that VM job; the build job is a container job, where harden-runner doesn't work.cancel-in-progress: truefor everything).deployjob are now gated to master as well as non-PR events, so aworkflow_dispatchfrom another branch no longer deploys./usr/local/cargo/{registry,git}andwasm/target, not~/.cargo/bin(the tools live in the image).lint.yml(the org's reusable lint, actionlint plusrenovate.json --strict).renovate.jsonextending the org preset. The preset already covers npm, Cargo and GitHub Actions. This repo adds two rules: npm git dependencies (comline-simulator,comline-examples) stay manual, like the Cargorev =pins, and npm updates wait 3 days, which respects Yarn'snpmMinimalAgeGate(one day by default in 4.18; it is not overridden).What stayed as it was, and why
yarn installwithout--immutable, andchecksumBehavior: updatein.yarnrc.yml: the sim's WASM isn't byte-reproducible, per the existing comment.git cloneof comline-rust at the pinned rev for the WASI generator: a source checkout, not a package install.Cargo.lockis committed (it is gitignored), sowasm-bindgen = "0.2"floats. wasm-pack used the image's CLI here (no download). If a 0.2.x newer than 0.2.127 is released, wasm-pack will fetch the matching CLI until the image is bumped.Verified on this PR
The
buildjob is green (wasm-pack, cargo tests, both wasip1 builds, sim install with its WASM build,yarn test,yarn build), as are lint and CodeQL.deployis skipped, as it should be on a PR.Only verifiable after merge
The first push to master runs the real
upload-pages-artifactanddeploy-pages(new SHAs, and Pages permissions now on the deploy job alone). No settings change is needed if Pages already deploys from Actions.