Repository navigation
conformance: vendor the specification at 0.11 (framing fact protocol) - #123
Merged
Merged
Conversation
Vendors ComlineProject/specification at 69882e9 (#9). The reference produces the new datagram@3 request-two-byte-protocol vector, and fact_shown holds a framing's `protocol` to the rule the specification states.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendors ComlineProject/specification#9 (spec 0.11, the framing fact
protocol), for ComlineProject/generation#137 step 2.spec/pinned at chore: relicense to MPL-2.0 #9's head,69882e92971e243b6b74a539a13b534d95b3abf7, which merges with a merge commit after this lands. The vendored tree also carries what the specification gained since the last pin (compiler/,specs/compiler.*,renovate.json).framing-datagram3/request-two-byte-protocol(00ac020105000000000000005b5d) with no change to any encoding;vectors_are_currentholds.protocol(named/unnamed) is a typed fact, kept in step with the catalog, andfact_shownjudges it by the specification's rule:namedby exact requests whose protocol is 128 or more, isn't their call id, and whose bytes hold its varint;unnamedby exact requests with no protocol. The cases must be of the profile's own framing.reports/rust.jsonlists the new case.