Repository navigation
CI hardening: CI tools image, pinned actions and toolchains, lint, Renovate - #6
Merged
Merged
Conversation
…ins, add lint and Renovate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4 of the org CI overhaul for this repo. Only
.github/,renovate.jsonandlint.ymlchange, so nothing a downstream repo vendors is touched.What changed
specsjob runs in the org'sci-toolsimage (by digest), which has cue v0.17.1 and jq, in place of downloading cue from a release (withcurland retries) on the runner. A new step fails if the image's cue is not the versioncue.mod/module.cuedeclares, so the two cannot drift apart unnoticed.rust cratejob: exact toolchains (1.99.1, and 1.82.0 for the minimum-Rust check) from the SHA-pinneddtolnay/rust-toolchain, in place ofrustup toolchain install stable. It stays on a VM because the image has neither clippy nor the wasm target nor the old Rust.ubuntu-24.04, top-levelpermissions: contents: read(no job needs more),persist-credentials: false, concurrency keyed on workflow and ref (cancels on PRs only),timeout-minuteson both jobs, every action SHA-pinned with a version comment, harden-runner (audit) on the VM job (it does not work in container jobs),defaults: run: shell: bash.lint.yml(the org's reusable lint: actionlint andrenovate.jsonvalidation) andrenovate.jsonextending the org preset.What stayed as it was, and why
specs/check.sh --check, theVERSIONcheck, and the crate's tests, clippy (-D warnings), MSRV check and wasm build are unchanged.rust-toolchain.toml: the crate lives under files other repos vendor, and this PR is kept to.github/,renovate.jsonandlint.yml. The toolchain versions are in the workflow instead (andrust-versionin Cargo.toml is untouched).Checked in this PR
All checks are green on the PR:
specs(in the image),rust crate, both lint jobs.Only verifiable after merge
Nothing: the push-to-main run is the same workflow as the PR run.