Repository navigation
CI hardening: PR build, pinned actions, wasm image, lint, Renovate - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4 of the org CI overhaul for the tutorial.
What changed
deploy.yml:deployjob are gated to pushes to main.ci-wasmimage (by digest), which has cargo, wasm-bindgen 0.2.127 and wasm-opt forcomline-simulator'sprepackWASM build; it needs no installs.24) through SHA-pinnedsetup-node;corepack enableprovidesyarn, which hands over to the committed Yarn 4.18.0.cache: yarnis replaced by an explicit cache of~/.yarn/berry/cache(Yarn's global cache, which holds the built simulator archive), sincesetup-node's cache needsyarnbefore Node exists in the container.runs-on: ubuntu-24.04,timeout-minutes, top-levelpermissions: contents: read,persist-credentials: false.pages: writeandid-token: writeon thedeployjob only, with harden-runner (audit) there. The build job is a container job, where harden-runner doesn't work.lint.yml(the org's reusable lint) andrenovate.jsonextending the org preset, which already covers npm and GitHub Actions. This repo adds: the simulator git pin stays manual, and npm updates wait 3 days so they respect Yarn'snpmMinimalAgeGate(one day by default in 4.18; not overridden).What stayed as it was, and why
COMLINE_SIMULATOR_SCRIPT: '0'(the tutorial only needs the lean sim), andyarn installwithout--immutable(the sim's WASM isn't byte-reproducible;checksumBehavior: update).Verified on this PR
build_siteis green: the simulator's WASM is built during install, thenyarn build. Lint and CodeQL are green.deployis skipped, as it should be on a PR.Only verifiable after merge
The first push to main runs the real
upload-pages-artifactanddeploy-pages(new SHAs).