fix(manifest): rewrite one empty state that spoke in tree jargon - #623
Merged
Conversation
Found by gate-96 (manifest-copy-style, ConductionNL/.github#581). The em-dash is what the gate detects; it is not what was wrong with the sentence. before: "No sub-competencies found - this is a leaf node (learning outcome)." after: "No sub-competencies. This is a learning outcome, the lowest level in the tree." "leaf node" is a data-structure term. A teacher looking at a competency that has nothing beneath it needs to know that is normal and expected, not that the record occupies a particular position in a graph. The parenthetical carried the only word that meant anything to them, so it is now the subject. "found" also goes: an empty state saying "none found" hints at a failed search, when the accurate statement is that there are none. Verified: gate-96 0 findings over 1,274 strings, check:manifest PASS, check:schema-l10n PASS.
Contributor
Quality Report — ConductionNL/learniq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 650/650 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-26 14:41 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
pushed a commit
that referenced
this pull request
Aug 26, 2026
⚠️ THE PR WAS CONFLICTING, AND ITS CHECKS WENT GREEN ANYWAY. Five checks passed where this branch normally runs 37 — a conflicted PR runs no real CI, so that green described nothing. The tell is the check COUNT, not the colour. Two of my changes had already been made on development while this branch was in flight, which is what conflicted: #610 navigate by path, not by hash — and it covers NINETEEN spec files, where I had fixed the four this branch made run. Theirs is the better change; I kept only the comments recording what the bug cost in these specs. #623 rewrote the same em-dash empty state gate-96 flagged, with better copy ("No sub-competencies. This is a learning outcome, the lowest level in the tree."). Took development's wording wholesale. Everything unique to this branch survives the merge, verified rather than assumed: seeded.ts, 26 requireFixture call sites, both named test.fixme declarations, the isLockedPeriod helper, the seeder's fixture block, and the `group-plan-subgroup` slug fix. Verified on the merged tree: seeder parses, prettier clean across the suite, eslint 0 errors, manifest is valid JSON, and gate-96 reports 1274 strings checked with no findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by gate-96 (
manifest-copy-style, ConductionNL/.github#581). The em-dash is what the gate detects; it is not what was wrong with the sentence."leaf node" is a data-structure term. A teacher looking at a competency with nothing beneath it needs to know that is normal and expected, not that the record occupies a particular position in a graph. The parenthetical carried the only word that meant anything to them, so it is now the subject.
"found" also goes. An empty state saying "none found" hints at a failed search, when the accurate statement is that there are none.
check:manifestcheck:schema-l10n