fix(dossier): the sixth lookup, and the bare limit param - #629
Closed
rubenvdlinde wants to merge 1 commit into
Closed
fix(dossier): the sixth lookup, and the bare limit param#629rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
#622 fixed the five schema lookups inside the Promise.all block. Two defects in the same method survived it. 1. The SIXTH lookup. DeliberationRecord is fetched separately, after the SupportRequest ids are known, so it sits outside the block the slug sweep covered. It 404'd for exactly the same reason: `DeliberationRecord` slugifies to `deliberationrecord`, the declared slug is `deliberation-record`. 2. `limit=500` without the underscore. A bare control param is applied by OpenRegister as a PROPERTY filter, so that asks for rows whose `limit` field equals 500 and returns an empty list with HTTP 200 - no error, no deliberations, silently. `learnerQuery` a few lines above already used `_limit=200`; this one call did not. So even with the slug corrected, the care chain would still have come back empty. Both are the tail of the same bug #622 documented, not a new one. Verified every remaining fetchSchema slug against lib/Settings/learniq_register.json and confirmed no bare `limit=` and no PascalCase call is left in the file.
Contributor
Author
|
Closing —
So the sixth lookup and the underscored control param both landed in parallel while this PR was in CI, and there is nothing left to merge. My branch conflicted on the explanatory comments alone. Keeping the reasoning here since it is the part that is not in the code: a bare control param is applied by OpenRegister as a property filter, so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #622, which fixed the five schema lookups inside the
Promise.allblock. Two defects in the same method survived it.1. The sixth lookup
DeliberationRecordis fetched separately, after the SupportRequest ids are known, so it sits outside the block the slug sweep covered. It 404s for exactly the same reason #622 documented:DeliberationRecorddeliberationrecorddeliberation-record2. A bare control param, three lines below
OpenRegister applies a bare control param as a property filter, so that asks for rows whose
limitfield equals 500 and returns an empty list with HTTP 200 — no error, no deliberations, silently.learnerQuerya few lines above already used_limit=200; this one call did not. So even with the slug corrected, the care chain would still have come back empty — a green request returning nothing.Verification
fetchSchemaslug checked againstlib/Settings/learniq_register.json— all presentlimit=and zero PascalCase calls left in the fileI had opened #627 with both of these plus the five #622 already covered; closing that in favour of this narrower one so the history stays clean.