Skip to content

fix(dossier): the sixth lookup, and the bare limit param - #629

Closed
rubenvdlinde wants to merge 1 commit into
developmentfrom
fix/dossier-deliberation-and-limit
Closed

fix(dossier): the sixth lookup, and the bare limit param#629
rubenvdlinde wants to merge 1 commit into
developmentfrom
fix/dossier-deliberation-and-limit

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Follows #622, which fixed the five schema lookups inside the Promise.all block. Two defects in the same method survived it.

1. The sixth lookup

DeliberationRecord is fetched separately, after the SupportRequest ids are known, so it sits outside the block the slug sweep covered. It 404s for exactly the same reason #622 documented:

passed slugifies to declared slug
DeliberationRecord deliberationrecord deliberation-record

2. A bare control param, three lines below

'limit=500'   // not '_limit=500'

OpenRegister applies a bare control param as a property filter, so that asks for rows whose limit field equals 500 and returns an empty list with HTTP 200 — no error, no deliberations, silently.

learnerQuery a few lines above already used _limit=200; this one call did not. So even with the slug corrected, the care chain would still have come back empty — a green request returning nothing.

Verification

  • every remaining fetchSchema slug checked against lib/Settings/learniq_register.json — all present
  • zero bare limit= and zero PascalCase calls left in the file
  • eslint clean

I had opened #627 with both of these plus the five #622 already covered; closing that in favour of this narrower one so the history stays clean.

#622 fixed the five schema lookups inside the Promise.all block. Two
defects in the same method survived it.

1. The SIXTH lookup. DeliberationRecord is fetched separately, after the
   SupportRequest ids are known, so it sits outside the block the slug
   sweep covered. It 404'd for exactly the same reason:
   `DeliberationRecord` slugifies to `deliberationrecord`, the declared
   slug is `deliberation-record`.

2. `limit=500` without the underscore. A bare control param is applied by
   OpenRegister as a PROPERTY filter, so that asks for rows whose `limit`
   field equals 500 and returns an empty list with HTTP 200 - no error,
   no deliberations, silently. `learnerQuery` a few lines above already
   used `_limit=200`; this one call did not. So even with the slug
   corrected, the care chain would still have come back empty.

Both are the tail of the same bug #622 documented, not a new one. Verified
every remaining fetchSchema slug against lib/Settings/learniq_register.json
and confirmed no bare `limit=` and no PascalCase call is left in the file.
@rubenvdlinde

Copy link
Copy Markdown
Contributor Author

Closing — development now carries both fixes. Verified against it directly:

development
PascalCase fetchSchema calls 0
bare limit= 0
'_limit=500' present
'deliberation-record' present

So the sixth lookup and the underscored control param both landed in parallel while this PR was in CI, and there is nothing left to merge. My branch conflicted on the explanatory comments alone.

Keeping the reasoning here since it is the part that is not in the code: a bare control param is applied by OpenRegister as a property filter, so limit=500 asks for rows whose limit field equals 500 and returns an empty list with HTTP 200 — meaning that even with the slug corrected, the care chain would still have come back empty, with no error anywhere to show for it.

@rubenvdlinde
rubenvdlinde deleted the fix/dossier-deliberation-and-limit branch August 26, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant