chore: ignore agent/test scratch and untrack generated files - #2863
Open
rubenvdlinde wants to merge 2 commits into
Open
chore: ignore agent/test scratch and untrack generated files#2863rubenvdlinde wants to merge 2 commits into
rubenvdlinde wants to merge 2 commits into
Conversation
Part of the 2026-08-25 fleet structure audit (ADR-100 Decision 2: the repository root is a closed set; generated files are never tracked). Ignore rules added: .stale/ /.e2e-state/ .phpunit.result.cache test-results/ playwright-report/ Untracked (kept on disk, now ignored where a rule covers them): - .phpunit.result.cache - composer-setup.php - composer.phar - no-admin-idor-findings.log - phpstan.phar `.stale/` was missing from ALL 19 fleet repos and is the one that matters most operationally: agent scratch there grew unbounded and filled the dev disk once already. Refs ConductionNL/hydra ADR-100.
rubenvdlinde
changed the title
Untracking composer.phar in the previous commit broke the Newman API suite: .github/workflows/api-test-coverage.yml ran `php composer.phar install` inside the nextcloud container, which ships no composer of its own. That is why the binary was committed in the first place. Rather than restore it, the workflow now copies the RUNNER's composer into the container (docker cp "$(command -v composer)") and calls `composer install`. The runner already has composer — the `composer install` step earlier in the same job uses it — so this removes the second copy instead of trading a committed binary for a network download. `command -v` fails loudly if composer is ever absent, rather than falling through to a missing binary and reporting the install failure as a test failure. A checked-in package-manager binary is the supply-chain shape ADR-100 Decision 2 forbids: never reviewed, never updated alongside the lockfile, and its provenance is a git history nobody reads. phpstan.phar, removed in the same sweep, is invoked nowhere — the only surviving mentions are composer.lock listing it as a package's own file and a design doc calling it binary noise.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 175/175 | |||
| npm | ✅ | ✅ 545/545 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ❌ | ||||
| Newman | ✅ | ||||
| Playwright | ❌ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-25 22:31 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 175/175 | |||
| npm | ✅ | ✅ 545/545 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-25 22:53 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the 2026-08-25 fleet structure audit — ADR-100 Decision 2 (the repository root is a closed set; generated files are never tracked).
Ignore rules added:
.stale/,/.e2e-state/.phpunit.result.cache,test-results/playwright-report/Untracked (left on disk; now covered by an ignore rule):
.phpunit.result.cachecomposer-setup.phpcomposer.pharno-admin-idor-findings.logphpstan.phar.stale/was missing from all 19 fleet repos. It is the one that matters most operationally: agent scratch accumulating there filled the dev disk once already.Every rule was verified to actually take effect by exit code (
git check-ignore -q), not by readingcheck-ignore -voutput — a!-negation prints as a match while doing the opposite, which is how one repo in this sweep looked covered and was not.Refs
ConductionNL/hydraADR-100.