Skip to content

fix(e2e): move the three fixme reasons where the gate can read them #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenvdlinde merged 1 commit into from
Aug 28, 2026
Merged

fix(e2e): move the three fixme reasons where the gate can read them #779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tests/e2e/workflows/crud-persistence.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,11 @@ test.describe('Contactpersoon CRUD-persistence', () => {
// pre-fill assertion below (the editor loads the row's stored values) and by
// the data-layer findAll cross-check. Re-enable once the deployed shell
// renders an object-data detail surface for the View action.
test.fixme('detail (View) -> shows the entered field values', async ({
page,
}) => {
test('detail (View) -> shows the entered field values', async ({ page }) => {
test.fixme(
true,
"the deployed nextcloud-vue CnIndexPage shell opens Nextcloud's generic right sidebar (Files / Notes / Tags / Audit trail) for the View action rather than an object-data detail panel, so the stored field values are not rendered for a UI assertion. A deployed-shell limitation, not a stackiq bug: persistence is proven by the Edit form pre-fill assertion below and the data-layer findAll cross-check.",
)
await gotoAppRoute(page, '/contactpersonen')
await dismissSupportDialog(page)

Expand Down
3 changes: 2 additions & 1 deletion tests/e2e/workflows/org-export-workflow.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,8 @@ test('export workflow: the seeded export org is retrievable via findAll', async
// container; every export endpoint returns "AMEF register ID is not
// configured"). Asserts a real AMEF/ArchiMate XML artifact once configured.
// ---------------------------------------------------------------------------
test.fixme('export workflow: produces an AMEF/ArchiMate artifact for the org (blocked: AMEF register not configured)', async () => {
test('export workflow: produces an AMEF/ArchiMate artifact for the org', async () => {
test.fixme(true, 'blocked: the AMEF register is not configured on this instance')
const res = await apiCtx.get(
`/index.php/apps/stackiq/api/archimate/export/organization/${seededOrgId}?modules=true&deelnames=true`,
)
Expand Down
8 changes: 5 additions & 3 deletions tests/e2e/workflows/organisatie-crud.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,11 @@ test('the create action opens the create dialog', async ({ page }) => {
// exactly like a passing test, and this one hid the fact that the whole create
// path had moved.
// ---------------------------------------------------------------------------
test.fixme('UI create -> new organisation card appears (unverified: body still drives the removed ObjectModal cascade)', async ({
page,
}) => {
test('UI create -> new organisation card appears', async ({ page }) => {
test.fixme(
true,
'unverified: the body still drives the removed ObjectModal cascade',
)
await navClickTo(page, 'Organisations')
await dismissSupportDialog(page)
const uiOrgName = `${RUN_ID} UI Organisatie`
Expand Down
Loading