Repository navigation
ci: report test coverage and enforce a minimum threshold - #44
Merged
Merged
Conversation
SizzleUnrlsd
force-pushed
the
test/18-colors-pty
branch
from
September 30, 2026 06:01
279453b to
b3abc98
Compare
SizzleUnrlsd
force-pushed
the
ci/19-coverage
branch
from
September 30, 2026 06:01
47f1fc8 to
9413f19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Coverageworkflow on Linux. It builds with--coverage -fprofile-update=atomic, runs the whole suite, then runs gcovr 8.6 onsrc/andinclude/, and publishes a markdown summary to the job summary.--fail-under-line). The summary is still published when it fails. A comment next to the threshold records where it comes from, so it can be raised as coverage grows.build/CMakeFilesthat gcov cannot resolve.With the tests from #14 and #15 (and #17, #18), line coverage goes from 48.7% on
main(llvm-cov) to 88.7% with GCC. What remains uncovered is mostly the defensive branches: EINTR and partial-write retries, thegmtimefailure path, and the unreachableif (!started)branch inwrite_hex().Stacked on #43.
Verification
llvm-cov gcov, AppleClang 17): lines 91.7%.--fail-under-line 90exits with 0 and--fail-under-line 99exits with 2.Closes #19