Repository navigation
docs(notice): credit Hugo Payet and the contributors, not CoreTrace - #291
Open
SizzleUnrlsd wants to merge 4 commits into
Open
SizzleUnrlsd wants to merge 4 commits into
SizzleUnrlsd wants to merge 4 commits into
Conversation
NOTICE named CoreTrace as the copyright holder, whereas the other CoreTrace repositories name the people who wrote their code. Here, Hugo Payet wrote most of it, Cédric Roulof bootstrapped the analyzer and another person contributed. Apache-2.0 licenses contributions without transferring their copyright, so NOTICE names Hugo Payet and the CoreTrace contributors.
NOTICE began with "CoreTrace Python Analyzer". It now begins with coretrace-python-analyzer, the name of the repository and of the package in pyproject.toml, as the NOTICE of the other CoreTrace repositories does.
Apache-2.0, section 4(d), requires derivative works to carry the attribution notices in NOTICE. With the repository's URL in it, every copy that follows the license points back to this project.
The wheel ships NOTICE (license-files in pyproject.toml), so the change reaches every installation and is listed for users.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NOTICEnamed CoreTrace as the copyright holder, whereas the other CoreTrace repositories name the people who wrote the code. Hugo Payet wrote most of this one, Cédric Roulof bootstrapped it, and Apache-2.0 does not transfer contributors' copyright. The file also named the project "CoreTrace Python Analyzer" and gave no URL. The other CoreTrace repositories get the sameNOTICE, starting with CoreTrace/coretrace-stack-analyzer#261.Change
NOTICEnamescoretrace-python-analyzer, the name of the repository and of the package, reads "Copyright 2026 Hugo Payet and the CoreTrace contributors" and gives the repository's URL, so every copy that reproduces it, as Apache-2.0 requires of derivative works, points back here. The license sentence is unchanged.CHANGELOG.mdlists the change under Unreleased, in a Documentation section.Verification
tests/test_packaging.pychecks thatNOTICEcontains "Copyright" and that the wheel ships it; both still hold, and CI runs the test.commit_checker.pyof coretrace-compiler, the strictest in the organization.