[SizzleUnrlsd]

Fixes #174

Problem

A diagnostic in a function defined in a header was reported in the file that includes the header, at the line it has in the header. 13 of the 22 diagnostic builders in DiagnosticEmitter.cpp set no file, and analyzeFile then spelled the empty path as the analyzed input.

Fix

At the end of AnalysisPipeline::run, assignFunctionFilesToDiagnostics gives each diagnostic without a file the file of its function, found by its LLVM name. LLVM names are unique in a module, so overloads and template instances are told apart. A file that a rule already set is kept, so locations such as IntegerOverflow's are unchanged. This covers the library API (analyzeModule) and the CLI. A diagnostic with no known function still falls back to the analyzed input.

Tests

• New check check_header_function_diagnostics_name_the_header covers a template, an inline function and a static C function. It compares full paths and lines. It fails on main in all 3 cases and passes with the fix.
• check_diagnostic_paths_follow_the_input (fix(report): spell every result's file as the input was given #124) passes before and after.
• CI-like suite (--compile-ir-cache-dir, unit tests included): 2384/2384 on macOS and on Linux x86_64.

Before / after (main daaf4cd vs this branch, Linux x86_64)

• Fixtures, default and z3 configurations: 846 runs, 0 differ, 1287 = 1287 diagnostics.
• Self-analysis, 4 chunks: 71 = 71 diagnostics. 3 diagnostics move to the header of their function, at the same line:
  • InstructionSubscriberRegistry::add: src/analyzer/AnalysisPipeline.cpp:37 -> include/analyzer/InstructionSubscriber.hpp:37
  • runCrossTUSummaryPass, both instances: src/app/AnalyzerApp.cpp:217 -> src/app/CrossTUSummaryDriver.hpp:217

Limits

• The function's file is a fallback. An instruction that is really inlined from another file would need its own LLVM debug location. A header always_inline function was checked, but the analyzer saw it uninlined, so that case is not proven.
• No test covers keeping a file a rule already set: today every rule that sets a file sets its function's file.
• Moving the 3 self-analysis results may close their code-scanning alerts and reopen them under new numbers. Triage will follow once CI has run.

Code scanning

CI is green on 10d4695: 13 checks pass, the release attach step is skipped.

• 66 open alerts on the merge ref, as on main. No github-advanced-security comment on this PR. No new coretrace-concurrency-analyzer alert.
• The 3 alerts that are new against main are main alerts moved by this fix to the header of their function. Each pair has the same rule and the same message:
  • #263 = ci(commit-check): check the pushed branch's commits, and let reverts through #150 (ConstParameterNotModified.Reference, InstructionSubscriberRegistry::add): src/analyzer/AnalysisPipeline.cpp:37 -> include/analyzer/InstructionSubscriber.hpp:37
  • #264 = docs: correct NOTICE, which named another CoreTrace project #261 and #265 = #262 (ConstParameterNotModified.ReferenceRvaluePreferValue, both instances of runCrossTUSummaryPass): src/app/AnalyzerApp.cpp:217 -> src/app/CrossTUSummaryDriver.hpp:217
• ci(commit-check): check the pushed branch's commits, and let reverts through #150, docs: correct NOTICE, which named another CoreTrace project #261 and #262 are not reported on this PR. Since the reported line now belongs to the function, these alerts should stop moving when lines are added above them in AnalyzerApp.cpp.