Skip to content

fix(app): capture the member, not the structured binding, for AppleClang 15 #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SizzleUnrlsd merged 2 commits into from
Oct 16, 2026
Merged

fix(app): capture the member, not the structured binding, for AppleClang 15 #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dc8830
ci: build on macos-14, whose AppleClang 15 is the oldest compiler Cor…
SizzleUnrlsd Oct 15, 2026
0b1cae7
fix(app): capture the member, not the structured binding, for AppleCl…
SizzleUnrlsd Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest]
# macos-14 builds with AppleClang 15 (Xcode 15.4), the oldest compiler CoreTrace builds
# the analyzer with; macos-latest has a newer one (#228).
os: [ubuntu-latest, macos-latest, macos-14]

steps:
- uses: actions/checkout@v4
Expand Down
6 changes: 4 additions & 2 deletions src/app/AnalyzerApp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1086,8 +1086,10 @@ static AppStatus analyzeWithSharedModuleLoading(const std::vector<std::string>&
continue;
if (common.params != wrapper.params)
common.pairs.clear();
std::erase_if(common.pairs,
[&](const auto& pair) { return wrapper.pairs.count(pair) == 0; });
// Captures the member, not the structured binding: AppleClang 15 cannot
// capture a structured binding.
std::erase_if(common.pairs, [&pairs = wrapper.pairs](const auto& pair)
{ return pairs.count(pair) == 0; });
}
}
grew = false;
Expand Down
Loading