Repository navigation
fix(action): diagnose unsupported Ubuntu LLVM versions - #257
Merged
SizzleUnrlsd merged 6 commits intoOct 31, 2026
Merged
Conversation
…me table The two case blocks restated which LLVM branches apt.llvm.org publishes for each Ubuntu release, a table that goes stale with every LLVM or Ubuntu release. Request the branch's Release file instead: a 200 lets the installation go on, while any other status, or no answer at all, stops the step with the URL and the status before the LLVM source is added.
LLVM 21 stops the build in coretrace-compiler v0.10.0, which the analyzer pins, and the analyzer's own sources use llvm::Attribute::NoCapture, which LLVM 21 removed. LLVM 19 fails in ResourceFactCollector.cpp. CI builds and tests LLVM 20 only, so reject any other llvm-version before apt runs, and name ubuntu-24.04, where the action is tested, when a runner has no LLVM 20 packages.
The input stays, so that workflows passing llvm-version: 20 keep working.
…LVM 20 The note sat between the sentence that introduces the workflow example and the example itself, and advertised LLVM 19 to 23 and Ubuntu 26.04. Describe what the action does instead, in the Notes list that follows the example: LLVM 20 from apt.llvm.org, tested on ubuntu-24.04, and an early error for any other version or a runner without LLVM 20 packages.
Contributor
|
Thanks again for this fix. We pushed the changes from our review on top of your two commits, so that it can be merged without another round trip:
Your keyring and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apt-keyflow with a dedicated LLVM keyring and asigned-bysource.llvm-version: 20only. The analyzer does not build with LLVM 21: the build stops in coretrace-compiler v0.10.0, and the analyzer's own sources usellvm::Attribute::NoCapture, which LLVM 21 removed. LLVM 19 fails as well, and CI builds and tests LLVM 20 only.Releasefile from apt.llvm.org. On a runner without LLVM 20 packages, such asubuntu-26.04, the step stops with the URL and the HTTP status instead of failing later inapt-get.llvm-versioninput and in the README notes.Fixes #255.
Validation
ubuntu-24.04with LLVM 20.action.ymland run withbash -eo pipefailas the step runs:ubuntu:24.04, LLVM 20: installs LLVM 20.1.8.ubuntu:26.04, LLVM 20: stops with status 404 and namesubuntu-24.04.ubuntu:24.04, LLVM 21: stops on the version check, beforeapt-getruns.ubuntu:24.04, apt.llvm.org unreachable: stops with statusunreachable.