Skip to content

fix(storage): count V2 catalog manifest CAS as logical refs - #1090

Merged
DecisionNerd merged 1 commit into
mainfrom
fix/1089-catalog-manifest-logical-refs
Sep 4, 2026
Merged

fix(storage): count V2 catalog manifest CAS as logical refs#1090
DecisionNerd merged 1 commit into
mainfrom
fix/1089-catalog-manifest-logical-refs

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Attribute each compact V2 graph-manifest CAS object as both a catalog logical reference and a physical identity.
  • Fail closed in qualification when any category reports physical_objects > logical_references.
  • Add regression coverage for multi-object catalog manifests (OVHC-AGENCY S18 assembly failure mode).

Closes #1089

Test plan

Made with Cursor


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: b1c5af9a-a067-4f24-a244-64372fb28123

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the core Core source code changes label Sep 4, 2026
@blacksmith-sh

This comment has been minimized.

@DecisionNerd

Copy link
Copy Markdown
Contributor Author

CI Gate on this PR is blocked by an independent demand-capture race (deferred one-hop expand drop leaking into the next optimized two-hop DemandSnapshot), not by the catalog/manifest attribution change.

Sibling fix: #1092 (closes #1091). After that merges to main, rebase/re-run this PR for exact-head CI Gate.

Compact graph-files manifests attributed physical CAS objects under
catalog_and_manifests without matching logical references, which made
OVHC-AGENCY S18 rung assembly fail closed after an otherwise passed lifecycle.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor
cursor Bot force-pushed the fix/1089-catalog-manifest-logical-refs branch from bb45527 to 1e3be72 Compare September 4, 2026 17:37
@DecisionNerd
DecisionNerd merged commit e57ccbb into main Sep 4, 2026
21 checks passed
@cursor
cursor Bot deleted the fix/1089-catalog-manifest-logical-refs branch September 4, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core source code changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(storage): count V2 catalog manifest CAS objects as logical references

1 participant