feat(identity): add Has Owner column to groups list - #495
Merged
KelvinTegelaar merged 2 commits intoSep 6, 2026
Conversation
Surfaces whether a group has an owner directly in the groups table instead of requiring the Owners row to be expanded, using the existing single-Graph-call expandOwners path (live) and the CIPPDB report cache (AllTenants/cached), so no extra Graph calls are added. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
sfaxluke
marked this pull request as draft
September 4, 2026 16:01
sfaxluke
force-pushed
the
feature/groups-missing-owner-column
branch
from
September 4, 2026 16:05
23ced1a to
8d538a2
Compare
sfaxluke
marked this pull request as ready for review
September 4, 2026 16:05
CI caught this: the existing "documented order" test pins the exact list of computed properties Set-CIPPDBCacheGroups appends, and the hasOwner property added in the previous commit shifted it without updating the assertion. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
bmsimp
added a commit
that referenced
this pull request
Sep 6, 2026
The groups list gained a Has Owner column in #495. Add the matching row to Table Details, after Owners, to mirror the column order in simpleColumns. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hasOwnerboolean to the Groups list response — live view via the existing (already-supported, just previously unused)expandOwnersGraph$expand, cached/AllTenants view via the CIPPDB report cache which already fetches owners.ownersCsvon the live path, since doing so would silently swap out the existing interactive "View owners" button (with its Add/Remove Owner actions) for a read-only text column.Test plan
Invoke-ListGroups.Tests.ps1,Get-CIPPGroupsReport.Tests.ps1— 7/7, including the-AsRawJsonblob-splicing tests)cachedColumn/sub-table swap logic this PR routes around (util-subTables.js) is byte-identical to when it was last tested — the frontend Vitest suite itself currently can't run ondevat all (unrelated pre-existingReferenceError: React is not definedin the shared theme, breaks every unit test, not caused by this PR)Closes #494
🤖 Generated with Claude Code