Repository navigation
Prepare validated JOSS submission candidate - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbsSAXS profiles can carry conflicting intensity-state or correction metadata at different levels. This candidate rejects those conflicts before absolute scaling, rejects explicitly non-absolute custom references, and validates the 2D polarization factor. Calibration results now describe the assumptions and partial scope of uncertainty estimates; the normalization formulas are unchanged.
The JOSS paper and README explain the research workflow, related software, and reproducible examples. Paper figures were regenerated at 140 mm width with vector sources and 600 dpi PNGs; the README cover is disclosed as conceptual AI-generated artwork. Packaging now uses a setuptools version compatible with the license metadata, and CI builds, checks, and clean-installs distributions.
Validation: 1,189 local tests passed on Python 3.12, the complete repository Ruff command passed, CLI examples and a clean optional-feature install passed, and the synthetic 2D canSAS export passed the official canSAS1d XSD. The JOSS paper is 1,211 words with 15 matched references. Cross-platform CI and the Inara PDF build run on this PR. Final author review of the new AI-assisted material remains explicitly pending in the submission record.