Repository navigation
Add recovery-only drain for gateway demo cutover - #86
Closed
randomblocker wants to merge 5 commits into
Closed
randomblocker wants to merge 5 commits into
randomblocker wants to merge 5 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
In recovery-only mode, Check & resume on a stored record with no jobId
re-POSTed /demo/procurement under the stored key. If the original POST
never reached the gateway, that created and paid for a new job after the
drain had paused new purchases (review round 1, P1/P2).
resumeDispatchDecision now takes { recoveryOnly } and returns
manual-reconcile instead of post for such a record. A job id learned by
another tab is still read. TryDacs keeps the record and shows its run id
for the operator.
Also from review: the default Playwright config ignores the recovery
spec, the recovery spec checks every fresh-start button plus the no-jobId
and raced-jobId cases, and the README and e2e/README note that the flag
is build-time and describe the second e2e pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add the gateway cutover procedure, accurate bundle and validation guidance, and a reconciliation request link. Exercise runAgent directly despite disabled controls in the recovery browser pass. Co-Authored-By: Codex <noreply@openai.com>
Contributor
Author
|
Closing as superseded by #84, which removes the gateway demo from the Community Directory entirely. The Butler-based demo is no longer used, so a drain phase before cutover isn't needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add recovery-only drain for gateway demo cutover
Summary
NEXT_PUBLIC_GATEWAY_DEMO_RECOVERY_ONLY=1) for the retiring Community-hosted buyer demoCheck & resumefor records with a gateway job id, including one another tab learned; records without a job id are never re-POSTed, stay stored, and show their run id and a reconciliation request linkWhy
Browser recovery state cannot move between origins. The old Community page needs a bounded drain phase that preserves read-only recovery for known job ids and provides an operator handoff for other records while the buyer demo moves to its gateway-owned UI.
Rollout
Follow the cutover procedure:
Idempotency-Key(the browser's run id).NEXT_PUBLIC_GATEWAY_DEMO_RECOVERY_ONLY=1.next buildinlines the flag, so changes require a rebuild. Tabs loaded before deployment keep their previous JavaScript until reloaded; the gateway gate must cover them.Validation
Head
fad9954, based on6c530ac, with maind1de29dalready merged:git diff --check: cleand1de29d: 13/13 passos.networkInterfaces()(uv_interface_addresses); the corresponding base browser pass fails at the same startup stepThe author reported 202 passing unit/integration tests, passing typecheck/build, and the original single Chromium recovery case at
803bffb. Those historical results do not validate the current four browser cases.