fuse: update atime locally and flush it via SETATTR - #190
Open
ukernel wants to merge 1 commit into
Open
Conversation
ukernel
force-pushed
the
fuse-atime
branch
2 times, most recently
from
July 20, 2026 15:54
d3d0f42 to
5d81fbf
Compare
Make fuse track kernel atime update and flush it back to the daemon via SETATTR. Dirty atime and ctime/mtime are tracked in the inode state, marked by inode's update_time() operation. SETATTR initiated by fuse_flush_times() only updates the timestamps that were dirty. Signed-off-by: "Yan, Zheng" <ukernel@gmail.com>
bsbernd
requested changes
Aug 5, 2026
bsbernd
left a comment
bsbernd
left a comment
Collaborator
There was a problem hiding this comment.
@ukernel why is this needed? The commit message should explain what is the issue. without that. Right now it ony explains what the code does.
Updating time stamps should only matter for write-back mode and mtime,atime already works without this change, imho.
Adding in atime updates on plain read will introduce lots of setattr rpcs - lazy-atime is there used almost everywhere - which is what fuse already does. Just imagine an 8000 node cluster that does atime update on every read from cache.
Exactly all these explanations are missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make fuse track kernel atime update and flush it back to the daemon via SETATTR. Dirty atime and ctime/mtime are tracked in the inode state, marked by inode's update_time() operation. SETATTR initiated by fuse_flush_times() only updates the timestamps that were dirty.