Repository navigation
Let activities be assigned to durable team objectives - #9
Merged
Merged
Conversation
Creating an objective from a team roadmap (the new UX) makes a team-owned objective with no set and no direct roadmap link. objective_on_roadmap didn't recognise that shape, so objective_assignable_to_roadmap returned False and the item API rejected it with "Invalid objective for this roadmap". Recognise a durable team objective (objective.team == roadmap.owning_team, sync on) as being on the roadmap, so items can be assigned to it. Regression test reproduces the flow: create objective via /api/objectives/ then assign an activity to it. Full suite 163 green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating an objective from a team roadmap (the new UX) makes a team-owned objective with no set and no direct roadmap link. objective_on_roadmap didn't recognise that shape, so objective_assignable_to_roadmap returned False and the item API rejected it with "Invalid objective for this roadmap".
Recognise a durable team objective (objective.team == roadmap.owning_team, sync on) as being on the roadmap, so items can be assigned to it. Regression test reproduces the flow: create objective via /api/objectives/ then assign an activity to it.
Full suite 163 green.