Skip to content

Bundle the 2026 GOLD native libraries from the GitHub mirror - #89

Merged
ryan-kipawa merged 3 commits into
masterfrom
build/ticket-03-gold-pins
Nov 11, 2026
Merged

ryan-kipawa merged 3 commits into
masterfrom
build/ticket-03-gold-pins

Conversation

@ryan-kipawa

Copy link
Copy Markdown
Collaborator

Summary

The build now bundles the 2026 GOLD native libraries, downloaded from the nuget-packages-2026 mirror release, because nuget.org doesn't have them yet.

-<packages source="nuget.org">
-  DFS, PFS, EUM, DHIfl, Projections, MikeCore.Linux.ubuntu22   23.0.3
+<packages source="github-mirror">
+  DFS, PFS, EUM, DHIfl, Projections                            24.1.2
+  MikeCore.Linux.ubuntu22                                      24.0.2
 setup()
   download from FEEDS[source]
   copy into mikecore/bin
-  check_signed("mikecore/bin/windows")
+  # check_signed(...)   the 2026 GOLD DLLs are unsigned; re-enable when switching back to nuget.org
   isolate the Linux libs (ADR 0002)
  • eumItem / eumUnit: regenerated with buildUtil/eumXMLProcess.py from the 24.x EUM.xml. This adds 3 wave items (110365–110367) and 4 units (5218–5221).
  • Docs:
    • AGENTS.md no longer says the build fails on an unsigned DLL.
    • The README no longer gives a version number for the bundled libraries.
    • The CHANGELOG marks the 2026 libraries as possibly breaking, because the Windows DLLs are unsigned.

Known caveats:

  • Unsigned DLLs: all seven Windows DLLs in the GOLD packages are unsigned; their PE certificate table is empty. Shipping them is a deliberate decision for now. ADR 0002 still describes signed DLLs and hasn't been amended.
  • Version mismatch: the five packages labelled 24.1.2 contain DLLs that report FileVersion 24.0.2.20020.
  • Switching back: once nuget.org publishes these packages, set source="nuget.org", update the versions if they differ, and turn check_signed back on.

Evidence

Local run on Linux (WSL):

  • Before (the mirror pins only):
    • RuntimeError: Bundled DLLs aren't signed: ... (all 7 DLLs).
    • With the check off, 5 EUM tests failed, for example ValueError: 110365 is not a valid eumItem from CreateItemHashtable and GetItemTypeTag.
  • After:
    • The hook printed Downloading NuGet packages from github-mirror, and all six packages came from the release.
    • Linux isolation passed (libeum.so → libeum-mikecore-python.so and so on).
    • pytest: 193 passed, 1 skipped, 8 xfailed, the same as master, with no xpasses.
    • ruff is clean, and pyrefly reports 0 errors and 328 warnings (the limit is 330).
    • The regenerated enums match the generator's output exactly: 643 items and 625 units.

Windows hasn't been run locally. This PR's CI is the first Windows run against the 24.x DLLs, and the first Linux CI build since #88, whose Linux jobs hit an apt outage.

Merge Danger

Door: two-way. Reverting restores the 23.0.3 pins and the signature check. Nothing is published until a v* release is cut.

Blast Radius: native-binaries

  • Every wheel built from master will bundle the 2026 libraries, including the next PyPI release.
  • Users whose Windows machines enforce WDAC or AppLocker may find the unsigned DLLs blocked.
  • Downstream code that relies on exact 23.0.3 behaviour, such as MIKE IO, may see differences. The "Test downstream MIKE IO" workflow can be run on this branch to check.

🤖 Generated with Claude Code

ryan-kipawa and others added 3 commits November 11, 2026 16:04
The packages config now uses source="github-mirror", with DHI.DFS,
DHI.PFS, DHI.EUM, DHI.DHIfl and DHI.Projections at 24.1.2 and
DHI.MikeCore.Linux.ubuntu22 at 24.0.2. Switch back to nuget.org once it
publishes them.

The Windows DLLs on the mirror are unsigned, so the build's signature
check is commented out until then. The Linux isolation check still runs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Regenerated eumItem and eumUnit with buildUtil/eumXMLProcess.py from the
24.x EUM.xml. It adds three wave items (110365-110367) and four units
(5218-5221), so item and unit lookups no longer fail on them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AGENTS.md no longer claims the build fails on an unsigned DLL, the README
drops the bundled version number, and the CHANGELOG marks the 2026 natives
as possibly breaking and drops the stale "wheel is unchanged" clause.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ryan-kipawa
ryan-kipawa merged commit 8d3cbac into master Nov 11, 2026
8 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant