Repository navigation
Bundle the 2026 GOLD native libraries from the GitHub mirror - #89
Merged
Merged
Conversation
The packages config now uses source="github-mirror", with DHI.DFS, DHI.PFS, DHI.EUM, DHI.DHIfl and DHI.Projections at 24.1.2 and DHI.MikeCore.Linux.ubuntu22 at 24.0.2. Switch back to nuget.org once it publishes them. The Windows DLLs on the mirror are unsigned, so the build's signature check is commented out until then. The Linux isolation check still runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Regenerated eumItem and eumUnit with buildUtil/eumXMLProcess.py from the 24.x EUM.xml. It adds three wave items (110365-110367) and four units (5218-5221), so item and unit lookups no longer fail on them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AGENTS.md no longer claims the build fails on an unsigned DLL, the README drops the bundled version number, and the CHANGELOG marks the 2026 natives as possibly breaking and drops the stale "wheel is unchanged" clause. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The build now bundles the 2026 GOLD native libraries, downloaded from the
nuget-packages-2026mirror release, because nuget.org doesn't have them yet.eumItem/eumUnit: regenerated withbuildUtil/eumXMLProcess.pyfrom the 24.xEUM.xml. This adds 3 wave items (110365–110367) and 4 units (5218–5221).AGENTS.mdno longer says the build fails on an unsigned DLL.Known caveats:
24.0.2.20020.source="nuget.org", update the versions if they differ, and turncheck_signedback on.Evidence
Local run on Linux (WSL):
RuntimeError: Bundled DLLs aren't signed: ...(all 7 DLLs).ValueError: 110365 is not a valid eumItemfromCreateItemHashtableandGetItemTypeTag.Downloading NuGet packages from github-mirror, and all six packages came from the release.libeum.so→libeum-mikecore-python.soand so on).Windows hasn't been run locally. This PR's CI is the first Windows run against the 24.x DLLs, and the first Linux CI build since #88, whose Linux jobs hit an apt outage.
Merge Danger
Door: two-way. Reverting restores the 23.0.3 pins and the signature check. Nothing is published until a
v*release is cut.Blast Radius: native-binaries
🤖 Generated with Claude Code