chore(deps): bump dig-store to 0.5.1 and dig-merkle to 0.4.5 - #39
Merged
Conversation
Both are pure re-locks: the existing caret pin `dig-store = "0.5"` already admitted 0.5.1, and dig-merkle moves transitively behind dig-store's `^0.4.3` bound (which does not admit 0.5.0). No manifest edit, no source change. The other three drifted dig-* pins (dig-wallet-backend 0.4 -> 0.27, dig-constants 0.5 -> 0.10, dig-chainsource-interface 0.1 -> 0.3) are NOT included. All three moved to the chia-protocol 0.36.1 / chia-wallet-sdk 0.34 / clvmr 0.16.2 generation while this workspace is on chia 0.26 / 0.30 / 0.14. The migration itself is tractable, but dig-store 0.5.1 still requires dig-chainsource-interface ^0.1, whose ChainSource trait is typed against chia-protocol 0.26 -- so get_store_status becomes uncallable once digstore-cli moves to 0.36.1, and digstore-cli cannot stay behind because it is welded to digstore-chain. That needs an upstream dig-store release first; landing it half-migrated would be worse than not bumping. Workspace version 0.23.0 -> 0.23.1 (patch: dependency-only, no API change). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Bumps this repo's
dig-*crates.io dependencies to their latest published versions. Two of thefive drifted pins land here; the other three are blocked on an upstream
dig-storerelease andare deliberately not half-applied — evidence below.
Landed
dig-storedigstore-cli/Cargo.toml:49already pins"0.5", which admits 0.5.1dig-merkledig-store(its^0.4.3bound does not admit 0.5.0)No manifest edit was needed for either; both are pure re-locks. Workspace version
0.23.0->0.23.1(patch: dependency patch bumps only, no public API change).Not landed — blocked upstream on
dig-storedig-wallet-backend0.4dig-constants0.5dig-chainsource-interface0.1dig-store 0.5.1requires^0.1All three moved to chia-protocol 0.36.1 / chia-wallet-sdk 0.34 / clvmr 0.16.2. This repo is on
chia 0.26 / chia-wallet-sdk 0.30 / clvmr 0.14. Those generations are semver-incompatible, so
cargo links both copies and the boundary types stop matching (
chia_protocol::Coin,BytesImpl<32>,CoinSpend).What I verified (not assumed)
I took the full chia 0.26 -> 0.36.1 migration to completion locally to find where it actually
stops, rather than declaring it blocked on inspection. Findings, in case a follow-up lane picks
this up:
The migration is tractable and mostly mechanical.
datalayer-driveris not a blocker —4.0.0is published against chia-protocol 0.36.1 /chia-wallet-sdk 0.34 / clvmr 0.16.2.
chiacrate publishes no 0.36.x (versions jump 0.32.0 -> 0.42.0). It must bereplaced by its constituents at 0.36.1:
chia-puzzle-types,chia-bls,chia-secp,clvm-utils,chia-consensus. That is a mechanical path rewrite across 15 files(
chia::puzzles::->chia_puzzle_types::,chia::consensus::->chia_consensus::, etc.).chia-sdk-coinset 0.34added a trailingcursor: Option<String>to everyget_coin_records_*method (5 call sites indigstore-chain/src/coinset.rs).PushTxResponse::statusbecameOption<String>.chia-sdk-driver 0.34removedCat::issue_with_coin;Cat::single_issuance(ctx, parent, None, amount, conds)is the equivalent (2 test call sites).chia-consensus 0.36droppedrun_spendbundle'sheightparameter. Worth flagging:rustc's suggested fix is to delete the
0argument, which silently passesHEIGHT(6_000_000) as the flags bitfield and measures a different cost model. The faithful port is
to reproduce what 0.26 did internally —
get_flags_for_height_and_constants(height, constants) | flags | MEMPOOL_MODE.digstore-chaincompiles clean on the new generation.Where it genuinely stops.
dig-store 0.5.1(the latest release) still requiresdig-chainsource-interface ^0.1, whoseChainSourcetrait is typed against chia-protocol 0.26.digstore-clicannot stay on 0.26 to match it — it is welded todigstore-chainand holding itback produces 105 cross-generation type errors across
ops/andcommands/. Sodig_store::get_store_statusbecomes uncallable andcommands/store_status.rsfails with 6errors:
Bridging that by hand would mean byte-level conversion of
Coin/CoinSpend/Bytes32between twochia generations inside the money-critical store-status lineage path. That is not a conversion I
am willing to hand-roll, and it is not what the ecosystem's release-first rule asks for.
Unblocking step (upstream, not this repo): release
dig-storeagainstdig-chainsource-interface ^0.3+ chia-protocol 0.36.1. Once that is on crates.io, the threeremaining bumps land together with the migration above.
Test result
Full workspace suite on the locked tree:
cargo test --workspace --locked167 suites, 1544 passed, 0 failed, 17 ignored (13 doctest suites included). Cargo exit 0.
Guest wasm built first (
cargo build -p digstore-guest --target wasm32-unknown-unknown --release)per the
digstore-stagebuild.rs BINDING contract.Also green:
cargo fmt --all --check, andcargo clippy --workspace --all-targets --lockedwith the CI lint set.
Blast radius
Lock-only dependency movement plus a workspace patch version. No source file changed, so no call
site moved.
crates/dig-client-wasmis workspace-excluded and has path dependencies only —nothing to bump there.