Skip to content

Fix checkbox indentation - #145

Merged
DinneK merged 1 commit into
mainfrom
Fix-checkbox-spacing
Sep 23, 2026
Merged

DinneK merged 1 commit into
mainfrom
Fix-checkbox-spacing

Conversation

@DinneK

@DinneK DinneK commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

module-name: Fix Checkbox Spacing

Problem

  • Nested checkbox lists were styled by the top-level .contains-task-list rule (padding-left: 0), so they rendered flush with their parent instead of indented.
  • USWDS renders the external-link icon via mask-image (not just background-image) in some versions, so mask-image: none (plus the -webkit- prefix) is needed to fully suppress it on TODO links.

Solution

  • Added .contains-task-list .contains-task-list override with padding-left: 1.75em so nested task lists indent without affecting top-level lists
  • Added mask-image: none; alongside existing -webkit-mask-image: none; to fully suppress USWDS's external-link icon on TODO links across browsers

Result

  • Nested checkboxes now render indented under their parent item, as intended
  • External-link icon no longer appears on TODO links in browsers that use the standard mask-image property

Test Plan

  • Test locally by:
  • Running: git run dev and navigating to http://localhost:8080/

Signed-off-by: Dinne Kopelevich <dinne.kopelevich1@cms.hhs.gov>
@DinneK DinneK self-assigned this Sep 23, 2026
@DinneK DinneK added enhancement New feature or request frontend labels Sep 23, 2026

@sachin-panayil sachin-panayil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DinneK
DinneK merged commit 7c93fe2 into main Sep 23, 2026
5 checks passed
@DinneK
DinneK deleted the Fix-checkbox-spacing branch September 23, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants