Cache Gradle distributions with MASS fallback - #12095
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: f39515c | Docs | Datadog PR Page | Give us feedback! |
🟡 Java Benchmark SLOs — Performance SLO warning (near threshold)
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
| internal const val MASS_READ_URL_ENV = "MASS_READ_URL" | ||
|
|
||
| /** Public Gradle distribution source. */ | ||
| internal const val UPSTREAM_DISTRIBUTIONS_BASE_URL = "https://services.gradle.org/distributions" |
There was a problem hiding this comment.
Can this be read from an ENV instead?
There was a problem hiding this comment.
Not really sure, there no other URLs other than https://services.gradle.org/distributions or am I missing something?
bric3
left a comment
There was a problem hiding this comment.
This looks fairly complex, for an issue we're not quite sure is a significant problem / pain point.
Also if that's an issue, why not handling retries within the tests ?
What Does This Do
MASS_READ_URLand retries withservices.gradle.orgif MASS is unavailable..gradle/wrapper, which is already included in the GitLab dependency cache.Motivation
Smoke tests downloaded the same Gradle 8.x distributions repeatedly, increasing load on the MASS pool and may causing intermittent GitLab failures when the pool was exhausted or temporarily unreachable.
This keeps internal infrastructure as the preferred source while allowing Gradle builds to continue when MASS cannot serve a distribution.
Additional Notes
.sha256file is available.404); Gradle does not advance to another repository on connection errors.