Skip to content

Send Feature Flagging API key fingerprint - #12115

Draft
leoromanovsky wants to merge 2 commits into
masterfrom
agent/ffe-api-key-fingerprint
Draft

Send Feature Flagging API key fingerprint#12115
leoromanovsky wants to merge 2 commits into
masterfrom
agent/ffe-api-key-fingerprint

Conversation

@leoromanovsky

@leoromanovsky leoromanovsky commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Motivation

The Feature Flags CDN needs a stable API-key identifier without writing the raw API key to CDN backend API logs. SDKs must send the Clifford v1 fingerprint so ffe-service can verify and log the fingerprint instead of the credential.

Changes and Decisions

  • Generate the Clifford v1 fingerprint with SHA-256 and the Datadog base62 format.
  • Send DD-API-KEY-FINGERPRINT with DD-API-KEY for Datadog-managed HTTPS endpoints.
  • Keep custom endpoint and insecure HTTP credential behavior unchanged.

@leoromanovsky leoromanovsky added tag: ai generated Largely based on code generated by an AI or LLM comp: openfeature OpenFeature type: feature Enhancements and improvements labels Jul 30, 2026
@datadog-official

datadog-official Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 85.00%
Overall Coverage: 75.77% (+17.99%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: fe91ced | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

🟡 Java Benchmark SLOs — Performance SLO warning (near threshold)

Suite Status
Startup 🟡 warning

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.00 s 13.96 s [-0.5%; +1.0%] (no difference)
startup:insecure-bank:tracing:Agent 12.97 s 12.93 s [-0.5%; +1.0%] (no difference)
startup:petclinic:appsec:Agent 16.84 s 16.67 s [+0.3%; +1.7%] (maybe worse)
startup:petclinic:iast:Agent 16.82 s 16.92 s [-1.4%; +0.3%] (no difference)
startup:petclinic:profiling:Agent 16.61 s 16.77 s [-2.0%; +0.0%] (no difference)
startup:petclinic:sca:Agent 16.08 s 15.93 s [-6.2%; +8.2%] (unstable)
startup:petclinic:tracing:Agent 16.11 s 15.99 s [-0.3%; +1.8%] (no difference)

Commit: fe91ced2 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@leoromanovsky
leoromanovsky marked this pull request as ready for review July 30, 2026 19:36
@leoromanovsky
leoromanovsky requested a review from a team as a code owner July 30, 2026 19:37
@leoromanovsky
leoromanovsky requested review from dd-oleksii, petzel and sameerank and removed request for a team July 30, 2026 19:37

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The independently executed SHA-256/base62 conversion produced the specified Clifford fingerprints for empty, ordinary, Unicode, leading-zero, and configured API-key inputs. The request path gates the new header behind the same managed-HTTPS condition as the API-key credential, so custom and HTTP endpoints remain excluded. No additional tests recommended: the existing test suite already covers the endpoint-routing and authoritative fingerprint vectors.

Was this helpful? React 👍 or 👎

📊 Validated against 5 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit fe91ced · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@sameerank sameerank left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been following the solution-ing around this. We'll be maintaining an internal map to decode the fingerprints?

@leoromanovsky
leoromanovsky marked this pull request as draft July 30, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: openfeature OpenFeature tag: ai generated Largely based on code generated by an AI or LLM type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants