Add index for instrumentation helper classes - #12116
Draft
sarahchen6 wants to merge 4 commits into
Draft
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
🟡 Java Benchmark SLOs — Performance SLO warning (near threshold)
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
…elper-class-index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Add build-time index (
helpers.index) for tracking instrumentation helper classes which maps modules to a helper class names table, and add a correspondingHelpersIndexfor generating and reading these classes. NowCombiningTransformerBuilderlooks up each module's helpers from this index instead of class-loading the module's $Muzzle at install. Fall back tohelperClassNames()for runtime-configured modules.Motivation
Without this index, helpers are resolved eagerly and negatively affect the startup time. Instead we can implement this index and replace the per-module class loads with one cheap read.
Additional Notes
This helper index uses
InstrumenterIndex's module ordering, so we can useinstrumentationIdto index directly.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]