Skip to content

fix: validate dependency updates and resolve SonarCloud findings - #169

Merged
Delemangi merged 1 commit into
mainfrom
fix/dependency-update-sonar-findings
Oct 28, 2026
Merged

Delemangi merged 1 commit into
mainfrom
fix/dependency-update-sonar-findings

Conversation

@Delemangi

Copy link
Copy Markdown
Owner

Summary

  • Include the dependency updates and refreshed lockfile for Electron, Node types, and eslint-config-imperium.
  • Resolve all five existing SonarCloud findings: name the image-number, message, and opacity controls; improve selection contrast to 8.28:1; remove commented-out markup.
  • Preserve application layout and behavior. The updated dependencies already pass build and lint without configuration changes.

Validation

  • npm ci --no-audit --no-fund
  • npm run build
  • npm run lint -- --no-cache
  • npm ls --depth=0
  • git diff --check
  • Queried SonarCloud: five open findings addressed, no unreviewed security hotspots.

Limitations

  • Local Sonar CLI analysis returned 403: Vortex analysis is unavailable for this connection. SonarCloud PR analysis must confirm the fixes server-side.
  • npm reported a blocked optional unrs-resolver postinstall script; installation, build, and lint still passed.

Copilot AI balanced review requested due to automatic review settings October 28, 2026 21:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@sonarqubecloud

Copy link
Copy Markdown

@Delemangi
Delemangi merged commit 7e35505 into main Oct 28, 2026
10 checks passed
@Delemangi
Delemangi deleted the fix/dependency-update-sonar-findings branch October 28, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants