Conversation
|
|
The output reading methods are fine, in my opinion. They just need some tests. The input class needs more attention:
The biggest question for me lies in the alternative obs_id is also relatively difficult to construct for a user, because its 2D (nobs * ndim). So for DIS it's shaped (nobs, 3), for DISV it's (nobs, 2) and for DISU it's (nobs, 1). So the grid form is probably more ergonomic in practice (or it should take a x, y, z constructor or something). Finally, there is the question of whether we need to expose some official logic to put the OBS output back on a grid. The utility in the example above , e.g. will only work if an entire layer is observed. In practice, one might want to place observations in different layers via a |



EDIT: convert to draft button doesn't seem to be working...
This enables the basic GWF OBS package. I've also added basic support for the output readers.
The
from_boolean_gridmight make it relatively easy to write results of selected areas/subdomains.In actual use, one might do:
We can then obviously read the results back in, as is:
A minor utility then suffices to convert back to a gridded form:
There are a number of relevant details, I'll make another note tomorrow.