Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manager summary
Adds a deterministic host-audition and timing-evidence package around the existing five-mode
PedalDelayEnginewithout changing the pedal UI, public parameter contract, engine implementation, or target firmware.This makes every compact mode reproducibly renderable and measurable for engineering review:
DIGITAPEMODREVFREEZEThe result is deliberately named
HOST_AUDITION_PACKAGE_READY, notHOST_LISTENED_ACCEPTEDorTARGET_READY.What changed
DaisyHost/tools/pedal_multidelay_audition/;std::nth_element;Real-Time DSP Profiling Systemv1.1 candidate;Public and parallel-work contract
Unchanged:
pedal_multidelay;PedalDelayEngine.h/.cpp;PedalDelayCore.h/.cpp;The final diff contains exactly seven newly added files. No pre-existing source, shared tracker, JUCE/UI file, engine file, core wrapper, or target-firmware file is modified.
Exact final evidence
PR head:
Base inspected:
Scoped multi-delay workflow
GitHub Actions
DaisyHost Pedal Multi-Delay Auditionrun31696153621: SUCCESS.Actually executed on the final PR head/merge ref:
PedalDelayCTest suite: 37/37 PASS;9179550895;10,391,426bytes;90f4a152b95475c305fe783a9749724c5fb3a9fcc024190219e705cadd66d865.Host-only timing evidence
Configuration:
These measurements are regression/characterization evidence for the CI host only. They are not converted into Cortex-M7 margin.
Repository checks
Fix Stylerun31696153590: SUCCESS using the repository-pinned clang-format 10 path;Build Allrun31696153589: SUCCESS for repository libraries, embedded examples, and distributable generation; deploy step skipped for the PR event as designed.Build Allis not the full DaisyHost/JUCE milestone gate and is not presented as such.Known real-time safety hold
The runner calls
PedalDelayEnginedirectly. The existing livePedalDelayCore::Process()wrapper still contains a scratch-vector growth fallback for an oversized callback. That shared wrapper file is intentionally untouched here.Current evidence boundary:
The smallest coordinated follow-up is to preallocate before audio start, fail closed on an oversized block, add a negative no-growth test, and rerun the focused/full DaisyHost gates.
Diagnostic precursor runs
Earlier source-branch runs intentionally exposed and corrected:
Those diagnostic failures did not modify the current runtime engine. The exact final-head workflow and repository style/build checks listed above are green.
Explicitly not claimed / not run
337/337plus Hub/Render/VST3/Standalone milestone gate;Review focus
PedalDelayCoreallocation-safety follow-up.