Skip to content

Support ICC computational clearing mode for CLEM datasets#823

Merged
tieneupin merged 4 commits into
mainfrom
support-icc-datasets
Jun 16, 2026
Merged

Support ICC computational clearing mode for CLEM datasets#823
tieneupin merged 4 commits into
mainfrom
support-icc-datasets

Conversation

@tieneupin

@tieneupin tieneupin commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

We were informed of the existence of another computational clearing (CC) mode offered by the CLEM.

This PR updates the workflow so that this CC mode is also supported. Slight improvements were made to the code to handle type hinting centrally via TypeAlias objects instead of manually typing out the identical, long types each time.

Instead of looking for the presence of a string pattern associated with the CC mode in the series name, the logic was adjusted so that this string pattern is only valid if found at the end of the series name.

Additionally, we switch from using the term 'denoising' to 'computational clearing'/'cc', as that is a more technically accurate indicator of the processing step's purpose. It does not subtract or remove noise, but rather identifies and subtracts out-of-focus background fluorescence from fluorescent images.

@tieneupin tieneupin force-pushed the support-icc-datasets branch from 445e1a2 to ff831e5 Compare June 12, 2026 18:11
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.95%. Comparing base (95769c0) to head (cb74925).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #823      +/-   ##
==========================================
+ Coverage   52.90%   52.95%   +0.04%     
==========================================
  Files          99       99              
  Lines       10760    10771      +11     
  Branches     1415     1418       +3     
==========================================
+ Hits         5693     5704      +11     
  Misses       4769     4769              
  Partials      298      298              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin marked this pull request as ready for review June 15, 2026 10:00
@tieneupin tieneupin self-assigned this Jun 15, 2026
@tieneupin tieneupin added enhancement New feature or request server Relates to the server component cryo-clem Part of the cryo-CLEM pipeline extension labels Jun 15, 2026

@stephen-riggs stephen-riggs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I like the change to be more generic so that denoising modes and colours can be added in a single place if needed

… accurately indicate what has happened with the dataset
@tieneupin tieneupin changed the title Support ICC denoising mode for CLEM datasets Support ICC computational clearing mode for CLEM datasets Jun 16, 2026
@tieneupin tieneupin merged commit 62abcff into main Jun 16, 2026
17 checks passed
@tieneupin tieneupin deleted the support-icc-datasets branch June 16, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cryo-clem Part of the cryo-CLEM pipeline extension enhancement New feature or request server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants