Search for a txrm reference is no internal one is present#826
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #826 +/- ##
==========================================
+ Coverage 52.90% 53.42% +0.51%
==========================================
Files 99 99
Lines 10760 10939 +179
Branches 1415 1454 +39
==========================================
+ Hits 5693 5844 +151
- Misses 4769 4787 +18
- Partials 298 308 +10 🚀 New features to boost your workflow:
|
tieneupin
reviewed
Jun 16, 2026
tieneupin
approved these changes
Jun 16, 2026
tieneupin
left a comment
tieneupin
left a comment
Contributor
There was a problem hiding this comment.
Some ongoing discussion how to handle "New folder", but looks good otherwise!
Contributor
|
Nice. Thanks for addressing my comment. Feel free to merge when you're ready. |
stephen-riggs
added a commit
to DiamondLightSource/cryoem-services
that referenced
this pull request
Jun 16, 2026
Allow an xrm file to be provided as an external reference for txrm processing. Also converts from using Optional to | Pairs with DiamondLightSource/python-murfey#826
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a txrm does not have an internal reference, instead of dismissing it search for a reference file in xrm format. Takes the most recent xrm which is not a mosaic image.
Still skips processing for txrms with less than 20 frames as these will be reference stacks.
Also changes the tilt series tags to remove angle naming, and skips transfer of "New folder"
Pairs with DiamondLightSource/cryoem-services#271