Skip to content

Match grid squares on sample rather than tag if sample known#827

Merged
stephen-riggs merged 4 commits into
mainfrom
grid-tag-match
Jun 16, 2026
Merged

Match grid squares on sample rather than tag if sample known#827
stephen-riggs merged 4 commits into
mainfrom
grid-tag-match

Conversation

@stephen-riggs

Copy link
Copy Markdown
Contributor

There is a problem with registering grid squares from an atlas, as the dcg tag is being used as the matching but this can change if atlas converts to SPA.

Instead, when registering squares from an atlas file, provide the sample and match this to a dcg. And send dcg request before that to make sure one will exist.

@stephen-riggs stephen-riggs requested a review from d-j-hatton June 16, 2026 10:16
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.93%. Comparing base (95769c0) to head (731e69b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
+ Coverage   52.90%   52.93%   +0.02%     
==========================================
  Files          99       99              
  Lines       10760    10763       +3     
  Branches     1415     1416       +1     
==========================================
+ Hits         5693     5697       +4     
+ Misses       4769     4768       -1     
  Partials      298      298              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@stephen-riggs stephen-riggs merged commit 9d375c2 into main Jun 16, 2026
17 checks passed
@stephen-riggs stephen-riggs deleted the grid-tag-match branch June 16, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants