Fully overwrite values in MillingStep entry upon update#832
Closed
tieneupin wants to merge 1 commit into
Closed
Conversation
…ly adding more truth-y values
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #832 +/- ##
=======================================
Coverage 53.11% 53.11%
=======================================
Files 100 100
Lines 10834 10834
Branches 1434 1434
=======================================
Hits 5754 5754
Misses 4775 4775
Partials 305 305 🚀 New features to boost your workflow:
|
Contributor
Author
|
Discussed and not needed. It's more practical to have a record of steps that were previously enabled than it is to fully follow the metadata. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the FIB milling progress registration logic is live, we have been able to start detecting bugs that weren't caught during testing.
In the FIB AutoTEM metadata, once a step is complete, the
is_enabledfield is set back toFalse. However, the current ISPyB insertion logic only supports the insertion and updating of truth-y values. Once the field is set toTrue, it can't be set back toFalseagain based on current logic.This PR fixes that by fully overwriting all values in an existing
MillingStepdatabase entry when updating it, instead of updating the value only when it's truth-y.