Repository navigation
fix: no building is lost in the free line along a section seam - #6
Merged
Merged
Conversation
ImportWorldBuildings now shares an outline when its footprint or the one-tile free line a section keeps around a building (CanPlace) reaches another section; the section importer refuses such an outline as outside its map, so it used to vanish at the seam. The section import skip reason no longer says 'Cell boundary' (buildings may cross native cells; that label was given to overlap/water/road failures) and names environment objects separately. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015ECCGjSrSADcjxBmXdCBpm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while assembling
PilnaVillage: real Pilna data, 21 sections of 1024 tiles, 4315 source buildings. This PR is stacked on #5.1. Seam-margin outlines were lost.
MapGenerator.CanPlacekeeps a one-tile free line inside each section, so an outline starting on a section's first column (or ending on its last) is refused by the section importer as "Outside the map".ImportWorldBuildingsonly shared outlines whose footprint corners lie in different sections, so it skipped these too, and they vanished. There were 10 in Pilna.2. The "Cell boundary" skip reason was misleading.
CanPlacefailure (overlap, water or road) of an outline that happened to cross a cell line.Results: core 345/345 passed,
npm test184/184 passed.Generated by Claude Code