Repository navigation
chore: 0.5.0 clean-up -- move TerraME validation to disslucc-benchmark - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clean-up release (0.5.0). The numerical comparison with TerraME/LuccME now lives in
LambdaGeo/disslucc-benchmark, which
pins a disslucc release; this repository keeps the package and examples to learn it
with. Everything removed is available in the
v0.4.0tag, which is untouched (thedissmodel JOSS paper cites it).
benchmark/goldens/and the golden, per-year, discriminance, validation andLua differential tests with their helpers; dropped the
lupadev dependency andexamples/run_lab1_validation.py/run_lab15_validation.py.run_continuous_real_data.py,run_continuous_executor.py,run_discrete_executor.py; TOML headers now say how torun each file locally with the CLI.
tests/test_executor_toml.py: each example TOML, run through the CLI, writes thesame output file (same SHA-256) as the equivalent hand-built experiment (continuous),
and runs reproducibly (discrete, saturation).
docs/validation.mdis now a short pointer to disslucc-benchmark andv0.4.0;README, quickstart, index, CLAUDE.md, CONTRIBUTING and issue templates updated.
components/demand/dates.py(two# type: ignore[override], one int→float conversion)..github/workflows/publish.yml(PyPI Trusted Publishing on release).CHANGELOG.mdandCITATION.cffupdated (repository URL unified toDisSModel/disslucc, author name order as in dissmodel).No change to
src/behaviour. disslucc-benchmark's 22 tests pass against this branch.Related Issue
Closes # n/a
Changes Made
src/disslucc/components/,executors/)tests/)Contributor Checklist
pytest tests/ -v) — 23 passedmypy src/disslucc) — alsoruff check .docs/validation.md(andpaper.md/paper.bibindissmodel, if applicable) is updated tomatch -- no result changes;
docs/validation.mdnow points to disslucc-benchmark,and the dissmodel paper (separate PR) cites the benchmark ids
(
lab01_md1643,lab15_md10)After merge
Release
v0.5.0on GitHub (publishes to PyPI and creates the Zenodo DOI), then pindisslucc==0.5.0in disslucc-benchmark and tag itv0.2.0.