Correct the figures that drifted, and check them from now on - #19
Merged
Merged
Conversation
The front page states four numbers under the heading "Numbers with the conditions they were measured under". Two of them were wrong. decisionrl ships 32 algorithms across 24 environments; the page said 31 and 22, the same stale pair its own README badges carried. Line coverage read 86%; the figure CI measures on the fast suite is 84.41%, and the threshold that fails the build is 80, so both halves of the sentence were off. Nothing recomputed any of it, which is the failure this organisation says it does not accept, on the one page where it says so. check_figures.py reads each figure's source -- decisionrl's CITATION.cff, which decisionrl's own tests pin to the package; glia's pyproject; Codecov -- and reports drift into one standing issue. recall@5 is reported as unverified rather than passed: praxis states it in prose with no eval run behind it, which is a gap in praxis to close there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two of the four figures under Numbers with the conditions they were measured under were wrong:
Both were the same stale pair the README badges carried. Fixed on the English and Russian pages.
scripts/check_figures.pynow reads each figure's source and reports drift into one standing issue, weekly. Verified: it passes on the corrected pages and fails on each old value, including the applied count that is spelled out in words rather than digits.recall@5 is deliberately reported as unverified rather than passed — praxis states it in prose with no eval run pinning it. That is a gap to close in praxis.