Publish /checks/, and move praxis's offline metrics out of the unchecked list - #21
Merged
Merged
Conversation
The page shipped this afternoon saying praxis states its retrieval figures in prose with nothing behind them. Half of that is now false: the offline column of the quality table is held by a test, because the offline path has no models, no network and no seed, so a run of it is reproducible. Correcting the table incidentally found that three of its five figures had been measured on a golden set of twelve and never re-measured when it grew to eighteen. What remains unchecked is the real-models column, and the entry says that precisely rather than gesturing at the whole table. A page whose second list is stale is worse than one without it.
The artefact is assembled from a named list, deliberately, so that a new top-level directory has to be added on purpose. /checks/ was not added. It was committed, it passed every structural check, and it served a 404 for twenty minutes while /ru/checks/ worked — because `ru` is copied whole and `checks` was not on the list. The comment above that list already said this would happen. Saying it is not the same as catching it, so the build now asks check_site.py which pages exist and fails naming any that never reached _site.
DenisDrobyshev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things, each its own commit.
1. /checks/ was never published.
pages.ymlassembles the artefact from a named list — deliberately, so a new top-level directory has to be added on purpose. I did not add it. The page was committed, passed every structural check, and served a 404 while/ru/checks/worked, becauseruis copied whole.The comment above that list already predicted this. The build now asks
check_site.pywhich pages exist and fails naming any that never reached_site; verified it passes on a correct build and fails namingchecks/index.htmlwhen the directory is dropped.2. praxis's offline metrics move out of the unchecked list. DrobyshevDev/praxis#41 pins the offline column of its quality table to a real run. The row moves into the pinned table; the unchecked entry narrows to the real-models column, which needs a GPU CI does not have.