Keep the checks page current, and check the counts written in words - #23
Merged
Merged
Conversation
Two guarantees have become real since the page shipped this afternoon, and a page whose value is its accuracy cannot lag behind them by a day. Every Python package here type-checks: praxis was the exception and had no mypy at all, while the organisation profile said "open source, typed, and tested". And no workflow runs an action taken from a moving tag any more -- all nine repositories pin by commit, and the weekly triage reports anything that drifts back, or says it could not read the workflows rather than calling them fine.
Every correction to those figures today changed digits: badges, CITATION.cff, .zenodo.json, pyproject, this site. The organisation profile says "Thirty-one algorithms and twenty-two environments" in words, and so came through all of it untouched -- the fifth surface carrying the stale pair, and the only one no check could see. The check reads the word in front of the noun rather than asking whether the right word appears somewhere: "thirty-two algorithms and twenty-four environments" contains both words, and presence alone cannot say which belongs to which. The recall entry is reworded while it is here. praxis states 0.92 and 0.94 in prose, the offline column of the same table is now pinned by a test, and the two should not be reported as one thing.
Reading a source through raw.githubusercontent.com can lag a merge by minutes. A weekly run never notices; someone running this by hand straight after fixing a figure sees the old value and starts debugging the wrong thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three things.
1. The checks page is current again — every Python package here type-checks (praxis was the exception), and no workflow runs an action from a moving tag.
2. The organisation profile was the fifth surface carrying the stale counts — "Thirty-one algorithms and twenty-two environments", in words, which is why every correction made to digits today went past it.
check_figures.pynow reads the word in front of the noun, not whether the right word appears somewhere: thirty-two algorithms and twenty-four environments contains both, and presence alone cannot say which belongs to which. Verified against the live profile — it names each stale word and what it should be.3. The recall entry is reworded. praxis states 0.92 / 0.94 in prose and the offline column of the same table is now pinned by a test; reporting them as one thing is what let the prose go unexamined.
The profile fix itself is in DrobyshevDev/.github#13.