Skip to content

Fix modified inductance element La to match its documented definition #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shaurya20335 wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −5
Open

Fix modified inductance element La to match its documented definition #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions impedance/models/circuits/elements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ def CPE(p, f):
return Z


@element(num_params=2, units=["H sec", ""])
@element(num_params=2, units=["H sec^(a - 1)", ""])
def La(p, f):
"""defines a modified inductance element as represented in [1]

Expand All @@ -225,7 +225,7 @@ def La(p, f):
"""
omega = 2 * np.pi * np.array(f)
L, alpha = p[0], p[1]
Z = (L * 1j * omega) ** alpha
Z = L * (1j * omega) ** alpha
return Z


Expand Down
15 changes: 12 additions & 3 deletions impedance/tests/test_circuit_elements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ def test_each_element():
(1.6541327179718126 - 0.537460300252313j),
],
"La": [
(0.21769191 + 0.07073239j),
(0.86664712 + 0.28159072j),
(3.45018434 + 1.12103285j),
(0.03450184 + 0.01121033j),
(0.13735431 + 0.04462912j),
(0.54681737 + 0.17767173j),
],
"G": [
(0.09999994078244179 - 0.00006283179105931961j),
Expand Down Expand Up @@ -98,6 +98,15 @@ def test_each_element():
circuit_elements["T"]([1, 2, 50, 100], [10000])


def test_La_linear_in_L():
# Z = L * (j omega)^alpha, so doubling L must double Z for any alpha
freqs = [0.001, 1.0, 1000]
La = circuit_elements["La"]
Z1 = La([0.1, 0.7], freqs)
Z2 = La([0.2, 0.7], freqs)
assert np.isclose(Z2, 2 * Z1).all()


def test_s():
a = np.array([5 + 6 * 1j, 2 + 3 * 1j])
b = np.array([5 + 6 * 1j, 2 + 3 * 1j])
Expand Down