Skip to content

[EDEN-2904] Require click>=8.5.0, drop auto_wrap_for_ansi workaround - #83

Merged
nicoddemus merged 1 commit into
masterfrom
eden-2904-click-8.5-auto-wrap-for-ansi
Sep 17, 2026
Merged

nicoddemus merged 1 commit into
masterfrom
eden-2904-click-8.5-auto-wrap-for-ansi

Conversation

@nicoddemus

@nicoddemus nicoddemus commented Sep 17, 2026 •

Copy link
Copy Markdown
Member

Summary

  • update-locks PRs bumping click to 8.5.0 fail with AttributeError: auto_wrap_for_ansi, since click 8.5.0 removed colorama-based ANSI wrapping on Windows entirely (Windows now enables ANSI terminal styles natively) — click.utils.auto_wrap_for_ansi was deleted, not renamed.

  • The deps_cli.py monkeypatch of that attribute (used by --force-color on Windows) is now both broken and unnecessary: click.echo(..., color=True) already writes raw ANSI codes directly without needing the patch.

Solution

  • Bumped the click dependency floor to >=8.5.0, removed the workaround and the now-unused colorama direct dependency, and updated uv.lock.

EDEN-2904

🤖 Generated with Claude Code

click 8.5.0 removed colorama-based ANSI wrapping on Windows entirely
(Windows now enables ANSI styles natively), which deleted
`click.utils.auto_wrap_for_ansi` and broke deps_cli.py's monkeypatch
of it. The workaround is no longer needed either: `click.echo(...,
color=True)` already writes raw ANSI codes directly.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@nicoddemus nicoddemus changed the title EDEN-2904: Require click>=8.5.0, drop auto_wrap_for_ansi workaround [EDEN-2904] Require click>=8.5.0, drop auto_wrap_for_ansi workaround Sep 17, 2026
@nicoddemus
nicoddemus requested a review from a team September 17, 2026 12:54
@nicoddemus
nicoddemus merged commit bd55eac into master Sep 17, 2026
3 checks passed
@nicoddemus nicoddemus mentioned this pull request Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants