Skip to content

fix(cli): Tag earthbuild/buildkitd binary pointed to by CLI correctly - #456

Merged
kmannislands merged 5 commits into
mainfrom
gh-335-gh-437-fix-tagging-of-buildkitd-version-shipped-in-binary-staging-test
Apr 29, 2026
Merged

fix(cli): Tag earthbuild/buildkitd binary pointed to by CLI correctly#456
kmannislands merged 5 commits into
mainfrom
gh-335-gh-437-fix-tagging-of-buildkitd-version-shipped-in-binary-staging-test

Conversation

@kmannislands

Copy link
Copy Markdown

Fixes #335 and #437

Prior to this fix, the released binaries point to the wrong (stagingci) docker repo.

For example from a recent build on main:

$ strings /Users/kieran/Downloads/22e40d18/earth-darwin-arm64 | rg docker.io/earthbuildci/
docker.io/earthbuildci/buildkitd-staging:22e40d18
-ldflags="-X main.DefaultBuildkitdImage=docker.io/earthbuildci/buildkitd-staging:22e40d18 -X main.Version=v0.8.18-22e40d18 -X main.GitSha=22e40d18791c3df67f383e44689d9fa32d5ee5c5 -X main.DefaultInstallationName=earth "
-ldflags="-X main.DefaultBuildkitdImage=docker.io/earthbuildci/buildkitd-staging:22e40d18 -X main.Version=v0.8.18-22e40d18 -X main.GitSha=22e40d18791c3df67f383e44689d9fa32d5ee5c5 -X main.DefaultInstallationName=earth "

These get copied as-is by the release automation on release (not rebuilt) per the plan in #76

Related almost-fixes:
#192
#219

I'll do a full release test of this branch and we should see the CLI binary produced by CI pointing to docker.io/earthbuild/buildkitd:v0.8.18-<hash> and the warning referenced in #335 and #437 go away

@kmannislands kmannislands self-assigned this Apr 22, 2026
@kmannislands
kmannislands requested a review from a team as a code owner April 22, 2026 17:17
@kmannislands
kmannislands requested review from gilescope and janishorsts and removed request for a team April 22, 2026 17:17

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the DEFAULT_BUILDKITD_IMAGE in release/Earthfile to use the $VERSION variable instead of $RELEASE_TAG. While this change correctly identifies the intended version, a critical issue was identified regarding argument propagation: the VERSION and DEFAULT_BUILDKITD_IMAGE arguments are not declared or passed down through the +all-binaries target and its dependencies in the root Earthfile, meaning the changes will be ignored during the build process.

Comment thread release/Earthfile
@github-actions

github-actions Bot commented Apr 22, 2026

Copy link
Copy Markdown

➖ Are we earthbuild yet?

No change in "earthly" occurrences

📈 Overall Progress

Branch Total Count
main 5557
This PR 5557
Difference +0

Keep up the great work migrating from Earthly to Earthbuild! 🚀

💡 Tips for finding more occurrences

Run locally to see detailed breakdown:

./.github/scripts/count-earthly.sh

Note that the goal is not to reach 0.
There is anticipated to be at least some occurences of earthly in the source code due to backwards compatibility with config files and language constructs.

@kmannislands
kmannislands force-pushed the gh-335-gh-437-fix-tagging-of-buildkitd-version-shipped-in-binary-staging-test branch from 1a2bed1 to c7d7a39 Compare April 23, 2026 16:02
@kmannislands
kmannislands merged commit e07a4f7 into main Apr 29, 2026
94 checks passed
@kmannislands
kmannislands deleted the gh-335-gh-437-fix-tagging-of-buildkitd-version-shipped-in-binary-staging-test branch April 29, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix warning on v0.8.17 release about unsupported version of buildkit

2 participants