fix(cli): Tag earthbuild/buildkitd binary pointed to by CLI correctly - #456
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the DEFAULT_BUILDKITD_IMAGE in release/Earthfile to use the $VERSION variable instead of $RELEASE_TAG. While this change correctly identifies the intended version, a critical issue was identified regarding argument propagation: the VERSION and DEFAULT_BUILDKITD_IMAGE arguments are not declared or passed down through the +all-binaries target and its dependencies in the root Earthfile, meaning the changes will be ignored during the build process.
➖ Are we earthbuild yet?No change in "earthly" occurrences 📈 Overall Progress
Keep up the great work migrating from Earthly to Earthbuild! 🚀 💡 Tips for finding more occurrencesRun locally to see detailed breakdown: ./.github/scripts/count-earthly.shNote that the goal is not to reach 0. |
…sh-version> rather than staging/alt namespace tags. release automation will just copy this binary
1a2bed1 to
c7d7a39
Compare
Fixes #335 and #437
Prior to this fix, the released binaries point to the wrong (stagingci) docker repo.
For example from a recent build on
main:These get copied as-is by the release automation on release (not rebuilt) per the plan in #76
Related almost-fixes:
#192
#219
I'll do a full release test of this branch and we should see the CLI binary produced by CI pointing to
docker.io/earthbuild/buildkitd:v0.8.18-<hash>and the warning referenced in #335 and #437 go away