Bump sharp and react-native-bootsplash - #6099
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
e7c844d to
4e9c02d
Compare
| "react-native-airship": "^0.3.0", | ||
| "react-native-battery-optimization-check": "^1.0.8", | ||
| "react-native-bootsplash": "^6.3.8", | ||
| "react-native-bootsplash": "^7.3.2", |
There was a problem hiding this comment.
Bootsplash 7 needs RN 0.80+
High Severity
react-native-bootsplash is bumped to ^7.3.2, but v7 officially requires React Native 0.80+. This repo still pins react-native at 0.79.2, so the upgrade can break native builds or splash behavior without a matching RN upgrade or staying on bootsplash 6.x.
Additional Locations (1)
Triggered by team rule: Use review sub agents
Reviewed by Cursor Bugbot for commit 4e9c02d. Configure here.
| "react-native-airship": "^0.3.0", | ||
| "react-native-battery-optimization-check": "^1.0.8", | ||
| "react-native-bootsplash": "^6.3.8", | ||
| "react-native-bootsplash": "^7.3.2", |
There was a problem hiding this comment.
Node engines allow unsupported Node 18
Medium Severity
This bump pulls in sharp 0.35.3 (and bootsplash 7), which require Node.js ≥20.9.0 / 20+, while package.json engines.node still allows >=18. Installs or bootsplash/sharp CLI use on Node 18 can fail even though the project still claims Node 18 is supported.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 4e9c02d. Configure here.
3e23c9d to
58b69ad
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 58b69ad. Configure here.
| }, | ||
| "engines": { | ||
| "node": ">=14.15.0" | ||
| "node": ">=20.9.0" |
There was a problem hiding this comment.
Sharp requires Node 20+
Medium Severity
sharp is now 0.35.3 with engines.node set to >=20.9.0, and bootsplash’s nested commander also requires Node 20+. The repo still declares "engines": { "node": ">=18" }, so Node 18 CI or local installs can fail when generating splash assets or installing optional native binaries.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 58b69ad. Configure here.
Bumps [sharp](https://github.com/lovell/sharp) to 0.35.3 and updates ancestor dependency [react-native-bootsplash](https://github.com/zoontek/react-native-bootsplash). These dependencies need to be updated together. Updates `sharp` from 0.32.6 to 0.35.3 - [Release notes](https://github.com/lovell/sharp/releases) - [Commits](lovell/sharp@v0.32.6...v0.35.3) Updates `react-native-bootsplash` from 6.3.8 to 7.3.2 - [Release notes](https://github.com/zoontek/react-native-bootsplash/releases) - [Commits](zoontek/react-native-bootsplash@6.3.8...7.3.2) --- updated-dependencies: - dependency-name: react-native-bootsplash dependency-version: 7.3.2 dependency-type: direct:production - dependency-name: sharp dependency-version: 0.35.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
58b69ad to
7d63b1b
Compare


Bumps sharp to 0.35.3 and updates ancestor dependency react-native-bootsplash. These dependencies need to be updated together.
Updates
sharpfrom 0.32.6 to 0.35.3Release notes
Sourced from sharp's releases.
... (truncated)
Commits
1018449Release v0.35.3ba303a7Prerelease v0.35.3-rc.24f94fc5Upgrade to sharp-libvips v1.3.2c5e7a3fBump devDeps, fix Deno/Windows smoke tests9a8d002Docs: Add changelog entry and note about transferable #45208694db0TypeScript: Return more preciseBuffer\<ArrayBuffer>fromtoBuffer(#4520)e000d0bPrerelease v0.35.3-rc.19554ca9Prerelease v0.35.3-rc.06a29fd5Emit warning about native binaries on Linux Electron540d2eaIncrease default concurrency when use of MALLOC_ARENA_MAX detectedMaintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for sharp since your current version.
Updates
react-native-bootsplashfrom 6.3.8 to 7.3.2Release notes
Sourced from react-native-bootsplash's releases.
... (truncated)
Commits
cfaccf2update sharp318d1e4Bump shell-quote from 1.8.3 to 1.8.4 in /example (#778)cd11928Bump webpack-dev-server from 5.2.3 to 5.2.4 in /example (#775)b4da367Bump@babel/plugin-transform-modules-systemjsin /example (#773)54e765eBump@babel/plugin-transform-modules-systemjsfrom 7.29.0 to 7.29.4 (#772)2168f3fBump@xmldom/xmldomfrom 0.8.12 to 0.8.13 in /example (#768)b583291Bump@xmldom/xmldomfrom 0.8.12 to 0.8.13 (#769)ae43f00Bump version number4779b0aRemove StyleSheet.absoluteFillObject usageea097a1Update dependenciesNote
Medium Risk
Major-version bootsplash upgrade can change native splash behavior at launch (especially Android edge-to-edge), though app code is unchanged. Lockfile also shifts image tooling to sharp 0.35 with stricter Node requirements for CLI/asset generation.
Overview
Dependency-only PR:
package.jsonbumpsreact-native-bootsplashfrom ^6.3.8 to ^7.3.2, withpackage-lock.jsonreflecting the full transitive tree (notablysharp0.32.6 → 0.35.3 and new@img/sharp-*optional platform packages).The app still wires splash the same way (
RNBootSplash.initon Android,BootSplash.hidefromEdgeCoreManager); there are no changes to app TS/Kotlin/Swift sources in this diff. Bootsplash v7 is a major release: Android is edge-to-edge by default, the Expo plugin can generate assets at prebuild, andisVisible()is synchronous—worth a quick smoke test on cold start on both OSes afterpod install/ rebuild.sharphere is primarily the bootsplash CLI asset pipeline (v0.35 drops the oldprebuild-installpath and requires Node ≥20.9 for native sharp installs). CI/dev machines on older Node may need attention; runtime wallet logic is unaffected.Reviewed by Cursor Bugbot for commit 7d63b1b. Bugbot is set up for automated code reviews on this repo. Configure here.