Skip to content

Match func_02038708 (ItemData::ApplyEffect) and document Item-related functions - #68

Merged
Eebit merged 3 commits into
mainfrom
item
Sep 8, 2026
Merged

Eebit merged 3 commits into
mainfrom
item

Conversation

@Eebit

@Eebit Eebit commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Closes #8 (hooray!).

@decomp-dev

decomp-dev Bot commented Sep 8, 2026

Copy link
Copy Markdown

Report for YFEE01 (3450c6b - 88de8ee)

📈 Matched code: 7.32% (+0.03%, +524 bytes)

✅ 15 new matches
Unit Item Bytes Before After
src/item ItemData::IsUsableOn(unsigned long, unsigned long) +976 0.00% 100.00%
src/item ItemData::IsUsableBy(Unit*) +900 0.00% 100.00%
src/item ItemData::ApplyEffect(Unit*) +524 0.00% 100.00%
src/item ItemData::ApplyEffect(Unit*, Unit*) +296 0.00% 100.00%
src/item ItemData::GetEffectiveJob(Unit*) +164 0.00% 100.00%
src/item ItemData::UnlocksDoor(Unit*) +92 0.00% 100.00%
src/item ItemData::UnlocksBridge(Unit*) +92 0.00% 100.00%
src/item ItemData::UnlocksChest(Unit*) +92 0.00% 100.00%
src/unit_item Item::CanReduceUses(Unit*) +92 0.00% 100.00%
src/item Item::IsRepairable() +80 0.00% 100.00%
src/item ItemData::GetStaffHealAmount(Unit*) +68 0.00% 100.00%
src/item ItemData::IsMagical() +60 0.00% 100.00%
src/unit_item Item::ReduceUses(Unit*) +52 0.00% 100.00%
src/item ItemData::GetMaxRange(Unit*) +40 0.00% 100.00%
src/item ItemData::GetHealAmount() +8 0.00% 100.00%
🥀 14 broken matches
Unit Item Bytes Before After
src/item func_02038914 -976 100.00% 0.00%
src/item func_02038384 -900 100.00% 0.00%
src/item func_02038ce4 -296 100.00% 0.00%
src/item GetJInfoFromItem -164 100.00% 0.00%
src/item func_02038e80 -92 100.00% 0.00%
src/item func_02038edc -92 100.00% 0.00%
src/item func_02038f38 -92 100.00% 0.00%
src/unit_item Item::func_0203e09c(Unit*) -92 100.00% 0.00%
src/item func_02038f94 -80 100.00% 0.00%
src/item func_02038e3c -68 100.00% 0.00%
src/item func_02038348 -60 100.00% 0.00%
src/unit_item Item::func_0203e0f8(Unit*) -52 100.00% 0.00%
src/item GetItemMaxRange -40 100.00% 0.00%
src/item func_02038e34 -8 100.00% 0.00%
📉 1 regression in an unmatched item
Unit Item Bytes Before After
src/item func_02038708 -509 97.21% 0.00%

@Eebit
Eebit marked this pull request as ready for review September 8, 2026 02:00
@Eebit
Eebit merged commit 83f8abc into main Sep 8, 2026
2 checks passed
@Eebit
Eebit deleted the item branch September 8, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Match func_02038708

1 participant