Conversation
The module captured screens and screens_inv once at load time, while util.get_ordered_screens() invalidates its own cache on screen added/ removed signals. After an output hotplug the stale tables no longer contained the current screen object, so screens_inv[ss] returned nil and capi.screen[nil].index raised 'attempt to index a nil value'. Fetch fresh tables in next_screen() and module.select_screen() and bail out gracefully when the lookup fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
screen.luacapturedscreens/screens_invonce at module load, whileutil.get_ordered_screens()invalidates its own cache onadded/removedsignalsscreens_inv[ss]returned nil for the current screen, andcapi.screen[nil].indexcrashed with "attempt to index a nil value"next_screen()andmodule.select_screen()now fetch fresh tables per call and bail out gracefully when the lookup failsTest plan
luac -p screen.luaparses cleanlyGenerated with Devin