GH-348 Post death command execution by Jakubk15 · Pull Request #348 · EternalCodeTeam/EternalCombat

Jakubk15 · 2026-02-20T09:40:35Z

This feature adds post-death command execution, suggested on our Discord server.
Dev build: https://cdn.discordapp.com/attachments/1327365890458779729/1474338540971364373/EternalCombat_v2.5.1-SNAPSHOT.jar?ex=69997c44&is=69982ac4&hm=05087586545d195a2b4f410813a897a39c669e05723dccf480110452a16de914&

gemini-code-assist · 2026-02-20T09:40:54Z

Summary of Changes

Hello @Jakubk15, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant new feature enabling server administrators to configure custom commands that execute automatically upon a player's death. This enhancement provides granular control over post-death events, allowing for different commands to be run by the console, the deceased player, or their killer, with options for deferred execution and combat-tagging conditions.

Highlights

Post-Death Command Execution: Implemented a new feature allowing configurable commands to be executed after a player's death, offering extensive customization for server administrators.
Configurable Command Sources: Introduced settings to define commands that can be run by the console, the dead player, or the killer, providing flexibility in how post-death events are handled.
Deferred Command Execution: Added options to defer the execution of certain commands until the player respawns, enabling more dynamic post-death scenarios.
Combat Tagging Condition: Included a setting to restrict post-death command execution only to combat-tagged players, ensuring commands are only triggered in relevant combat situations.
Build System Updates: Updated build configurations to include a new dependency, EternalCore, and updated the target Minecraft version.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

buildSrc/src/main/kotlin/Versions.kt
- Added the ETERNALCORE version constant.
eternalcombat-plugin/build.gradle.kts
- Reordered import statements for better organization.
- Updated the target Minecraft version from 1.21.10 to 1.21.11.
- Configured the runServer task to download EternalCore as a modrinth plugin.
eternalcombat-plugin/src/main/java/com/eternalcode/combat/CombatPlugin.java
- Reordered import statements for consistency.
- Moved the java.time.Duration import to a more appropriate section.
- Registered the new DeathCommandController to handle post-death command logic.
eternalcombat-plugin/src/main/java/com/eternalcode/combat/config/implementation/CommandSettings.java
- Added consolePostDeathCommands to specify commands executed by the console after death.
- Introduced deferConsoleAfterRespawn to control when console commands are executed.
- Added deadPostDeathCommands for commands executed by the dead player.
- Included deferDeadAfterRespawn to control when dead player commands are executed.
- Added killerPostDeathCommands for commands executed by the killer.
- Introduced onlyExecuteIfTagged to restrict command execution to tagged combat scenarios.
eternalcombat-plugin/src/main/java/com/eternalcode/combat/config/implementation/PluginConfig.java
- Updated comments for the commands section to reflect the new post-death and logout command execution features.
eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/death/DeathCommandController.java
- Added a new class DeathCommandController responsible for listening to player death and respawn events.
- Implemented logic to execute configured post-death commands based on various conditions (console, dead player, killer).
- Included functionality for deferring command execution until respawn and handling combat tag requirements.
- Provided placeholder replacement for player and killer names in commands.

Activity

No human activity (comments, reviews, etc.) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

The pull request introduces post-death command execution, a feature suggested by the community. This includes adding new configuration options for console, dead player, and killer commands, along with logic to defer command execution until respawn. The changes also update dependency versions and import statements. Overall, the implementation seems to address the requested feature effectively, but there are a few areas for improvement regarding code clarity and placeholder consistency.

gemini-code-assist · 2026-02-20T09:48:59Z

+        if (this.config.commands.onlyExecuteIfTagged) {
+            return;
+        }


The onlyExecuteIfTagged check is performed here, but it's only for PlayerDeathEvent. If onPlayerUntag is also meant to respect this setting, the check should be moved to executeDeathCommands or duplicated in onPlayerUntag to ensure consistent behavior.

I tested it and I wasn't able to produce any bugs, however I encourage other team members to try it nevertheless

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

…t/death/DeathCommandController.java Co-authored-by: DMK <81445555+imDMK@users.noreply.github.com>

…o feature/post-death-commands # Conflicts: # eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/death/DeathCommandController.java

…t/death/DeathCommandExecutor.java Co-authored-by: Piotr Zych <77621271+P1otrulla@users.noreply.github.com>

…, clarify config comments

Pawelusze · 2026-07-26T09:17:05Z

+            return;
+        }
+
+        UUID playerUniqueId = player.getUniqueId();


Why is the UUID called playerUniqueId in some places and playerUUID in others?

These names were picked during coding, no particular reason

Yeah, just pointing it out. My bad asking it as a question

vLuckyyy

The code works, but it feels overengineered for such a simple feature. My main concern is the dependency on event ordering and the state stored in killerNames and handledByUntag, since unusual flows or a player disconnecting could leave stale entries or cause commands to run twice.

ConcurrentHashMap also seems unnecessary here. I would simplify the flow, resolve the killer only once, clean up the stored state on quit, and reduce the number of classes, because Controller + Service + Executor + Resolver is a bit too much for this logic.

Jakubk15 · 2026-07-26T20:50:11Z

Thanks for feedback @vLuckyyy. I suggest we discuss this PR further in our Discord. The last sentence of what you just wrote is the opposite of @imDMK review

Jakubk15 added 2 commits February 20, 2026 09:56

WIP: Post death command execution

8dfe353

Post death command execution

e333117

Jakubk15 requested review from CitralFlo, imDMK and vLuckyyy February 20, 2026 09:40

Jakubk15 added the 🆕 feature New feature or request label Feb 20, 2026

Jakubk15 changed the title ~~Post death command execution~~ GH-348 Post death command execution Feb 20, 2026

gemini-code-assist Bot reviewed Feb 20, 2026

View reviewed changes

Jakubk15 and others added 4 commits February 20, 2026 10:57

Apply suggestions from code review

16f45ca

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

fix build

13d9c09

adjust to gemini's suggestion

911ef7b

Remove CauseOfTag.LOGOUT from the check

ce87394

CitralFlo requested changes Feb 21, 2026

View reviewed changes

CitralFlo mentioned this pull request Feb 21, 2026

GH-343 fix: block namespaced commands during combat and add regression test #343

Open

vLuckyyy reviewed Feb 21, 2026

View reviewed changes

Comment thread buildSrc/src/main/kotlin/Versions.kt Outdated

Comment thread ...ombat-plugin/src/main/java/com/eternalcode/combat/config/implementation/CommandSettings.java Outdated

imDMK requested changes Feb 25, 2026

View reviewed changes

Jakubk15 and others added 8 commits March 15, 2026 17:57

Update eternalcombat-plugin/src/main/java/com/eternalcode/combat/figh…

356481e

…t/death/DeathCommandController.java Co-authored-by: DMK <81445555+imDMK@users.noreply.github.com>

Update eternalcombat-plugin/src/main/java/com/eternalcode/combat/figh…

2a99c85

…t/death/DeathCommandController.java Co-authored-by: DMK <81445555+imDMK@users.noreply.github.com>

Adjust to Mike's suggestions. Simplify logic

320dd90

Merge remote-tracking branch 'origin/feature/post-death-commands' int…

903fdaa

…o feature/post-death-commands # Conflicts: # eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/death/DeathCommandController.java

Merge branch 'master' into feature/post-death-commands

cb015b5

fix build

15b2267

Change EternalCore version to latest stable

115f8bb

Adjust to DMK's suggestion

a606358

Jakubk15 requested review from CitralFlo and imDMK March 22, 2026 08:02

Move to DeathSettings

dc0724b

CitralFlo approved these changes Apr 24, 2026

View reviewed changes

Comment thread eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/death/DeathSettings.java

Merge branch 'master' into feature/post-death-commands

81afc4c

Jakubk15 added 3 commits July 9, 2026 13:58

Merge branch 'master' into feature/post-death-commands

bc83f4d

Fix build

34b1252

Add additional comments per Mike's suggestion

6b09a6f

Jakubk15 requested review from P1otrulla, Pawelusze and vLuckyyy July 22, 2026 07:40

P1otrulla approved these changes Jul 24, 2026

View reviewed changes

Comment thread eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/death/DeathCommandExecutor.java Outdated

Comment thread eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/death/DeathCommandExecutor.java Outdated

Jakubk15 and others added 4 commits July 25, 2026 13:35

Update eternalcombat-plugin/src/main/java/com/eternalcode/combat/figh…

7bc712d

…t/death/DeathCommandExecutor.java Co-authored-by: Piotr Zych <77621271+P1otrulla@users.noreply.github.com>

Update eternalcombat-plugin/src/main/java/com/eternalcode/combat/figh…

ca25b99

…t/death/DeathCommandExecutor.java Co-authored-by: Piotr Zych <77621271+P1otrulla@users.noreply.github.com>

Update placeholders in settings

b9d6a5b

Add scheduler support for post-death command execution, improve logic…

ca05679

…, clarify config comments

Pawelusze reviewed Jul 26, 2026

View reviewed changes

vLuckyyy requested changes Jul 26, 2026

View reviewed changes

vLuckyyy added 2 commits July 26, 2026 23:41

Simplify whole code.

fd94fe1

Simplify config declaration.

f6f3e3b

Uh oh!

Uh oh!

Conversation

Jakubk15 commented Feb 20, 2026

Uh oh!

gemini-code-assist Bot commented Feb 20, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Jakubk15 Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pawelusze Jul 26, 2026

Choose a reason for hiding this comment

Uh oh!

Jakubk15 Jul 26, 2026

Choose a reason for hiding this comment

Uh oh!

Pawelusze Jul 26, 2026

Choose a reason for hiding this comment

Uh oh!

vLuckyyy left a comment

Choose a reason for hiding this comment

Uh oh!

Jakubk15 commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Jakubk15 commented Jul 26, 2026 •

edited

Loading