Skip to content

test: stabilize provider deadline verification #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
EvanProgramming wants to merge 1 commit into
base: Evan/v3-native-plan-guard
Choose a base branch
from
Draft

test: stabilize provider deadline verification #318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions tests/test_task_consistency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import json
import subprocess
import tempfile
import threading
import time
import unittest
from openkyrozen.tools.models import ToolResult
Expand Down Expand Up @@ -995,38 +996,52 @@ def test_failed_operation_can_retry_and_provider_deadline_is_honest(self):
self.assertEqual(failed.failure, "command_failed")
self.assertTrue(retried.success)

entered, release, finished = threading.Event(), threading.Event(), threading.Event()
class SlowProvider:
def chat(self, _messages, _model):
time.sleep(0.2)
entered.set()
release.wait(5)
finished.set()
return "late", None

original_provider = main.llm_provider
main.llm_provider = SlowProvider()
try:
with patch.object(main, "_provider_timeout_seconds", return_value=0.01):
started = time.monotonic()
with patch.object(main, "_provider_timeout_seconds", return_value=0.1):
response = main._get_llm_response([])
self.assertTrue(entered.wait(2), "provider worker did not start")
self.assertFalse(finished.is_set(), "provider returned before timeout completed")
finally:
release.set()
finished.wait(2)
main.llm_provider = original_provider
self.assertLess(time.monotonic() - started, 0.1)
self.assertTrue(finished.is_set(), "provider worker did not finish after release")
self.assertIn("Provider timed out", response)

def test_streaming_provider_obeys_deadline_and_discards_late_chunks(self):
entered, release, finished = threading.Event(), threading.Event(), threading.Event()
class SlowStreamingProvider:
def chat_stream(self, _messages, _model):
time.sleep(0.2)
yield "late"
entered.set()
release.wait(5)
try:
yield "late"
finally:
finished.set()

original_provider = main.llm_provider
main.llm_provider = SlowStreamingProvider()
chunks = []
try:
with patch.object(main, "_provider_timeout_seconds", return_value=0.01):
started = time.monotonic()
with patch.object(main, "_provider_timeout_seconds", return_value=0.1):
response = main._get_llm_response([], stream=True, on_chunk=chunks.append)
self.assertTrue(entered.wait(2), "provider worker did not start")
self.assertFalse(finished.is_set(), "provider returned before timeout completed")
finally:
release.set()
finished.wait(2)
main.llm_provider = original_provider
self.assertLess(time.monotonic() - started, 0.1)
self.assertTrue(finished.is_set(), "provider worker did not finish after release")
self.assertIn("Provider timed out", response)
self.assertEqual(chunks, [])

Expand Down
Loading